Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4172 Clean up java warnings in the hadoop-mapreduce-project sub projects
  3. MAPREDUCE-4181

Remove the unused maybeInitBuilder() method from various classes in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      Clean up a bunch of existing javac warnings in hadoop-yarn-api module.

        Activity

        Hide
        Harsh J added a comment -

        Patch that cleans up all the warnings. Some warnings still may exist in generated sources but I can't do anything about those - perhaps a protobuf update may solve it automatically.

        Show
        Harsh J added a comment - Patch that cleans up all the warnings. Some warnings still may exist in generated sources but I can't do anything about those - perhaps a protobuf update may solve it automatically.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523702/0009-YARN-API-Cleanup.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.yarn.server.TestContainerManagerSecurity

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2282//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2282//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523702/0009-YARN-API-Cleanup.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2282//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2282//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        The failure of org.apache.hadoop.yarn.server.TestContainerManagerSecurity is unrelated to this patch. Its been failing for a while across all builds.

        Show
        Harsh J added a comment - The failure of org.apache.hadoop.yarn.server.TestContainerManagerSecurity is unrelated to this patch. Its been failing for a while across all builds.
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Could you revise the summary and description for reflecting the actual changes? "Clean up yarn-api" sounds like changing the Yarn APIs. How about "Remove the unused maybeInitBuilder() method from various classes in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/"?

        Show
        Tsz Wo Nicholas Sze added a comment - Could you revise the summary and description for reflecting the actual changes? "Clean up yarn-api" sounds like changing the Yarn APIs. How about "Remove the unused maybeInitBuilder() method from various classes in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/"?
        Hide
        Harsh J added a comment -

        Fixing summary per Nicholas' comments.

        Thanks Tom and Nicholas for the review.

        Show
        Harsh J added a comment - Fixing summary per Nicholas' comments. Thanks Tom and Nicholas for the review.
        Hide
        Harsh J added a comment -

        Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future.

        Closing out parent JIRA MAPREDUCE-4172, and hence closing out this.

        Show
        Harsh J added a comment - Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future. Closing out parent JIRA MAPREDUCE-4172 , and hence closing out this.

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development