Details

    • Release Note:
      The Job Summary log may contain commas in values that are escaped by a '\' character. This was true before, but is more likely to be exposed now.
    • Target Version/s:

      Description

      We occasionally use jobsummary from the JobTracker to collect users' slot usage on our clusters. It would be useful if the jobname was part of this jobsummary so that I don't need to join with other logs.

      Same jobsummary.
      2012-03-15 16:05:55,919 INFO mapred.JobInProgress$JobSummary: jobId=job_201202160624_1089972,submitTime=1331827523632,launchTime=1331827528197,firstMapTaskLaunchTime=1331827536917,firstReduceTaskLaunchTime=1331827541251,firstJobSetupTaskLaunchTime=1331827528200,firstJobCleanupTaskLaunchTime=1331827551655,finishTime=1331827555919,numMaps=1,numSlotsPerMap=1,numReduces=1,numSlotsPerReduce=1,user=tortuga,queue=queue1,status=SUCCEEDED,mapSlotSeconds=13,reduceSlotsSeconds=10,clusterMapCapacity=___,clusterReduceCapacity=___

      I'd like to see "jobName" added to the end.

      1. MAPREDUCE-4017-v0.20-1.patch
        0.7 kB
        Koji Noguchi
      2. MAPREDUCE-4017.patch
        3 kB
        Thomas Graves

        Activity

        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop-1.0.3.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop-1.0.3.
        Hide
        Matt Foley added a comment -

        Merged to branch-1.0 for 1.0.3, at TGraves request.

        Show
        Matt Foley added a comment - Merged to branch-1.0 for 1.0.3, at TGraves request.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1046/)
        MAPREDUCE-4017. Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1046/ ) MAPREDUCE-4017 . Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1011/)
        MAPREDUCE-4017. Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1011/ ) MAPREDUCE-4017 . Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #224 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/224/)
        svn merge -c 1311972 from trunk. FIXES: MAPREDUCE-4017. Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311974)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311974
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #224 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/224/ ) svn merge -c 1311972 from trunk. FIXES: MAPREDUCE-4017 . Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311974) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311974 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2056 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2056/)
        MAPREDUCE-4017. Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2056 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2056/ ) MAPREDUCE-4017 . Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2043 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2043/)
        MAPREDUCE-4017. Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2043 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2043/ ) MAPREDUCE-4017 . Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2117/)
        MAPREDUCE-4017. Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2117/ ) MAPREDUCE-4017 . Add jobname to jobsummary log (tgraves and Koji Noguchi via bobby) (Revision 1311972) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311972 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobSummary.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
        Hide
        Robert Joseph Evans added a comment -

        Thanks Koji and Tom. I put this into trunk, branch-1, branch-2, and branch-0.23

        Show
        Robert Joseph Evans added a comment - Thanks Koji and Tom. I put this into trunk, branch-1, branch-2, and branch-0.23
        Hide
        Robert Joseph Evans added a comment -

        Oh I forgot +1

        Show
        Robert Joseph Evans added a comment - Oh I forgot +1
        Hide
        Robert Joseph Evans added a comment -

        The patches look good, my only comment on them is that up to this point nothing in the job summary log was directly controllable by the user. The job name is, and it may make correctly parsing the data more difficult then it was before. The SummaryBuilder escapes commas with a '\', but anyone doing the simple thing that the tests do, line.split(',') will not work correctly. I am not sure if there is much we can do about it, except add it to the release notes.

        Show
        Robert Joseph Evans added a comment - The patches look good, my only comment on them is that up to this point nothing in the job summary log was directly controllable by the user. The job name is, and it may make correctly parsing the data more difficult then it was before. The SummaryBuilder escapes commas with a '\', but anyone doing the simple thing that the tests do, line.split(',') will not work correctly. I am not sure if there is much we can do about it, except add it to the release notes.
        Hide
        Thomas Graves added a comment -

        test failures are known and not caused by this change.

        Show
        Thomas Graves added a comment - test failures are known and not caused by this change.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522004/MAPREDUCE-4017.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
        org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
        org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
        org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2178//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2178//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522004/MAPREDUCE-4017.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2178//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2178//console This message is automatically generated.
        Hide
        Thomas Graves added a comment -

        Thanks for the patch Koji. Here is the corresponding trunk/branch-2 patch.

        I've tested on both branch1 and trunk on single node clusters and verified the output as well.

        Show
        Thomas Graves added a comment - Thanks for the patch Koji. Here is the corresponding trunk/branch-2 patch. I've tested on both branch1 and trunk on single node clusters and verified the output as well.
        Hide
        Koji Noguchi added a comment -

        For 0.20.2XX/1.X .

        Show
        Koji Noguchi added a comment - For 0.20.2XX/1.X .

          People

          • Assignee:
            Thomas Graves
            Reporter:
            Koji Noguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development