Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4001

Improve MAPREDUCE-3789's fix logic by looking at job's slot demands instead

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: capacity-sched
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In MAPREDUCE-3789, the fix had unfortunately only covered the first time assignment scenario, and the test had not really caught the mistake of using the condition of looking at available TT slots (instead of looking for how many slots a job's task demands).

      We should change the condition of reservation in such a manner:

                if ((getPendingTasks(j) != 0 &&
                     !hasSufficientReservedTaskTrackers(j)) &&
      -                (taskTracker.getAvailableSlots(type) !=
      +                !(j.getNumSlotsPerTask(type) >
                        getTTMaxSlotsForType(taskTrackerStatus, type))) {
      

      I had not realized during the earlier ticket that j.getNumSlotsPerTask(type) did exist.

        Issue Links

          Activity

          Harsh J created issue -
          Harsh J made changes -
          Field Original Value New Value
          Attachment MAPREDUCE-4001.patch [ 12518183 ]
          Harsh J made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Harsh J made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 1.1.0 [ 12317960 ]
          Resolution Fixed [ 1 ]
          Harsh J made changes -
          Target Version/s 1.1.0 [ 12317960 ]
          Harsh J made changes -
          Link This issue relates to MAPREDUCE-516 [ MAPREDUCE-516 ]
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Harsh J
              Reporter:
              Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development