Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3922

Fix the potential problem compiling 32 bit binaries on a x86_64 host.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 0.23.2
    • Component/s: build, mrv2
    • Labels:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixed build to not compile 32bit container-executor binary by default on all platforms.

      Description

      MAPREDUCE-3880 specifies that -m32 be passed to gcc to ensure that a 32-bit binary is built. On my Amazon Linux with a x86_64 architecture, I could not build the native container-executor because the configure script exited with an error when trying to use gcc (version 4.4.5) with this flag.

      Adds a comment to hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml regarding package requirement for glibc-devel.i686 or glibc-devel.i386 package on yum-based (RHEL, Centos, Amazon) Linux distributions.

      1. MAPREDUCE-3922.patch
        1 kB
        Eugene Koontz
      2. MR-3922.1.patch
        1 kB
        Hitesh Shah

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1004 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1004/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1004 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1004/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/210/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah.
          svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448)

          Result = FAILURE
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/210/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #969 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/969/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446)

          Result = UNSTABLE
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #969 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/969/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446) Result = UNSTABLE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #182 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/182/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah.
          svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #182 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/182/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #607 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/607/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah.
          svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448)

          Result = ABORTED
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #607 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/607/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448) Result = ABORTED vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1802 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1802/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446)

          Result = ABORTED
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1802 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1802/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446) Result = ABORTED vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #593 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/593/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah.
          svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #593 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/593/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #606 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/606/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah.
          svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #606 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/606/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. svn merge --ignore-ancestry -c 1294446 ../../trunk (Revision 1294448) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294448 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1792 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1792/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1792 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1792/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1866 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1866/)
          MAPREDUCE-3922. Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1866 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1866/ ) MAPREDUCE-3922 . Fixed build to not compile 32bit container-executor binary by default on all platforms. Contributed by Hitesh Shah. (Revision 1294446) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Just committed to trunk, branch-0.23 and branch-0.23.1. Thanks Hitesh!

          Show
          Vinod Kumar Vavilapalli added a comment - Just committed to trunk, branch-0.23 and branch-0.23.1. Thanks Hitesh!
          Hide
          Bruno Mahé added a comment -

          Patch looks good!
          Thank you very much Eugene and Hitesh!

          Show
          Bruno Mahé added a comment - Patch looks good! Thank you very much Eugene and Hitesh!
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Thanks for the verification Eugene.

          Patch looks good, +1.

          Pushing this in.

          Show
          Vinod Kumar Vavilapalli added a comment - Thanks for the verification Eugene. Patch looks good, +1. Pushing this in.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          I am changing the title because we are fixing it with a place holder instead of documenting it.

          Show
          Vinod Kumar Vavilapalli added a comment - I am changing the title because we are fixing it with a place holder instead of documenting it.
          Hide
          Eugene Koontz added a comment -

          +1 on Hitesh's patch. Works well for me:

          {{
          cd ~/hadoop/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager && mvn clean install package -DskipTests -Dtar -Dcontainer-executor.additional_cflags="-m32" -Pdist,native && file `find . -name "container-executor" -type f`

          }}

          yields:

          ./target/native/target/usr/local/bin/container-executor: ELF 32-bit LSB executable, Intel 80386, version 1 (GNU/Linux), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, not stripped
          

          while:

           cd ~/hadoop/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager && mvn clean install package -DskipTests -Dtar  -Pdist,native && file `find . -name "container-executor" -type f`
          

          yields:

          ./target/native/target/usr/local/bin/container-executor: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, not stripped
          
          Show
          Eugene Koontz added a comment - +1 on Hitesh's patch. Works well for me: {{ cd ~/hadoop/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager && mvn clean install package -DskipTests -Dtar -Dcontainer-executor.additional_cflags="-m32" -Pdist,native && file `find . -name "container-executor" -type f` }} yields: ./target/ native /target/usr/local/bin/container-executor: ELF 32-bit LSB executable, Intel 80386, version 1 (GNU/Linux), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, not stripped while: cd ~/hadoop/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager && mvn clean install package -DskipTests -Dtar -Pdist, native && file `find . -name "container-executor" -type f` yields: ./target/ native /target/usr/local/bin/container-executor: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, not stripped
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12516199/MR-3922.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1940//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1940//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516199/MR-3922.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1940//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1940//console This message is automatically generated.
          Hide
          Hitesh Shah added a comment -

          Attaching a patch which actually addresses the issue in question. The pom now has a placeholder which can be modified as per the build's requirements.

          Pass -Dcontainer-executor.additional_cflags=" -m32 " if a 32-bit build is needed. By default, this value is unset.

          Show
          Hitesh Shah added a comment - Attaching a patch which actually addresses the issue in question. The pom now has a placeholder which can be modified as per the build's requirements. Pass -Dcontainer-executor.additional_cflags=" -m32 " if a 32-bit build is needed. By default, this value is unset.
          Hide
          Allen Wittenauer added a comment -

          s,Mahadev,Hitesh,g

          Show
          Allen Wittenauer added a comment - s,Mahadev,Hitesh,g
          Hide
          Allen Wittenauer added a comment -

          I'm adding Arun and Mahadev to this issue, since they helped create this mess.

          Show
          Allen Wittenauer added a comment - I'm adding Arun and Mahadev to this issue, since they helped create this mess.
          Hide
          Allen Wittenauer added a comment -

          The real fix is to revert the hardcode, not document a specific fix for a specific OS packaging system. While I know there are lots of places in the native code where this is done, it is NEVER safe to hard-code CFLAG and LDFLAG settings without testing the validity of those values.

          Show
          Allen Wittenauer added a comment - The real fix is to revert the hardcode, not document a specific fix for a specific OS packaging system. While I know there are lots of places in the native code where this is done, it is NEVER safe to hard-code CFLAG and LDFLAG settings without testing the validity of those values.
          Hide
          Eugene Koontz added a comment -

          Thanks to Bruno Mahé for mentioning this related JIRA.

          Show
          Eugene Koontz added a comment - Thanks to Bruno Mahé for mentioning this related JIRA.
          Hide
          Peter Linnell added a comment -

          -1 Forcing people to build 32bit on 64 bit machines is a no go.

          Show
          Peter Linnell added a comment - -1 Forcing people to build 32bit on 64 bit machines is a no go.
          Hide
          Bruno Mahé added a comment -

          This patch does not work for me. I can't find the aforementioned packages on my debian.

          We should remove the -m32, make it a parameter so by default it builds natively. This also blocks others trying to work on other architectures such as ARM. See HADOOP-7276 for instance.
          Building 32bits on 64bits should be an extra steps for those who need it instead of making an extra step to build 64bits on their native system.

          Show
          Bruno Mahé added a comment - This patch does not work for me. I can't find the aforementioned packages on my debian. We should remove the -m32, make it a parameter so by default it builds natively. This also blocks others trying to work on other architectures such as ARM. See HADOOP-7276 for instance. Building 32bits on 64bits should be an extra steps for those who need it instead of making an extra step to build 64bits on their native system.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12515988/MAPREDUCE-3922.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1928//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1928//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515988/MAPREDUCE-3922.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1928//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1928//console This message is automatically generated.

            People

            • Assignee:
              Hitesh Shah
              Reporter:
              Eugene Koontz
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development