Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: build, mrv2
    • Labels:
      None

      Description

      Currently we can't pass in -m32 to LCE build.

      1. MAPREDUCE-3880.patch
        0.9 kB
        Arun C Murthy

        Issue Links

          Activity

          Hide
          Arun C Murthy added a comment -

          Point taken Allen, my bad. Thankfully, it's fixed via MAPREDUCE-3922.

          Show
          Arun C Murthy added a comment - Point taken Allen, my bad. Thankfully, it's fixed via MAPREDUCE-3922 .
          Hide
          Vinod Kumar Vavilapalli added a comment -

          So this patch just broke a bunch of folks and should be reverted. It is NEVER safe to hard-code CFLAG and LDFLAG values. EVER!

          Being fixed as part of MAPREDUCE-3922.

          Show
          Vinod Kumar Vavilapalli added a comment - So this patch just broke a bunch of folks and should be reverted. It is NEVER safe to hard-code CFLAG and LDFLAG values. EVER! Being fixed as part of MAPREDUCE-3922 .
          Hide
          Allen Wittenauer added a comment -

          So this patch just broke a bunch of folks and should be reverted. It is NEVER safe to hard-code CFLAG and LDFLAG values. EVER!

          Show
          Allen Wittenauer added a comment - So this patch just broke a bunch of folks and should be reverted. It is NEVER safe to hard-code CFLAG and LDFLAG values. EVER!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #994 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/994/)
          MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245867)

          Result = SUCCESS
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #994 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/994/ ) MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245867) Result = SUCCESS acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/200/)
          Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245868)

          Result = FAILURE
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/200/ ) Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245868) Result = FAILURE acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #172 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/172/)
          Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245868)

          Result = SUCCESS
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #172 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/172/ ) Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245868) Result = SUCCESS acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #959 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/959/)
          MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245867)

          Result = SUCCESS
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #959 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/959/ ) MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245867) Result = SUCCESS acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #575 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/575/)
          Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245868)

          Result = ABORTED
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #575 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/575/ ) Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245868) Result = ABORTED acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1762 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1762/)
          MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245867)

          Result = ABORTED
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1762 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1762/ ) MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245867) Result = ABORTED acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12515074/MAPREDUCE-3880.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1893//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1893//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515074/MAPREDUCE-3880.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1893//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1893//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #559 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/559/)
          Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245868)

          Result = SUCCESS
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #559 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/559/ ) Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245868) Result = SUCCESS acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1751 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1751/)
          MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245867)

          Result = SUCCESS
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1751 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1751/ ) MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245867) Result = SUCCESS acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #572 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/572/)
          Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245868)

          Result = SUCCESS
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #572 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/572/ ) Merge -c 1245867 from trunk to branch-0.23 to fix MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245868) Result = SUCCESS acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245868 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1825 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1825/)
          MAPREDUCE-3880. Changed LCE binary to be 32-bit. (Revision 1245867)

          Result = SUCCESS
          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1825 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1825/ ) MAPREDUCE-3880 . Changed LCE binary to be 32-bit. (Revision 1245867) Result = SUCCESS acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245867 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          Hide
          Arun C Murthy added a comment -

          I just committed this to block 23.1-rc2.

          Show
          Arun C Murthy added a comment - I just committed this to block 23.1-rc2.
          Hide
          Arun C Murthy added a comment -

          Thanks Hitesh. Since it's a trivial and harmless change to the build, I'll commit.

          Show
          Arun C Murthy added a comment - Thanks Hitesh. Since it's a trivial and harmless change to the build, I'll commit.
          Hide
          Hitesh Shah added a comment -

          lgtm. +1

          Show
          Hitesh Shah added a comment - lgtm. +1
          Hide
          Arun C Murthy added a comment -

          This hardcoding should suffice for 23.1 since it's ok to have the LCE be 32-bit since we don't need much memory for it and should work on all platforms.

          We can make a better fix for 23.2.

          Show
          Arun C Murthy added a comment - This hardcoding should suffice for 23.1 since it's ok to have the LCE be 32-bit since we don't need much memory for it and should work on all platforms. We can make a better fix for 23.2.

            People

            • Assignee:
              Arun C Murthy
              Reporter:
              Arun C Murthy
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development