Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3879

yarn script has vestiges of jsvc that need to be cleaned up

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 0.23.0
    • Fix Version/s: None
    • Component/s: mrv2, nodemanager
    • Labels:
      None

      Description

      If nodemanager is started under root (I know, I know). The following is displayed:

      /usr/lib/jvm/java-6-sun/bin/java -Dproc_nodemanager -Xmx1000m -jvm server -Dhadoop.log.dir=/var/log/yarn -Dyarn.log.dir=/var/log/yarn -Dhadoop.log.file=yarn-yarn-nodemanager-ahmed-laptop.log -Dyarn.log.file=yarn-yarn-nodemanager-ahmed-laptop.log -Dyarn.home.dir=/usr/lib/hadoop -Dhadoop.root.logger=INFO,DRFA -Dyarn.root.logger=INFO,DRFA -Djava.library.path=/usr/lib/hadoop/lib/native -classpath /etc/hadoop/conf:/etc/hadoop/conf:/etc/hadoop/conf:/usr/lib/hadoop/share/hadoop/common/*::/usr/lib/hadoop/*:/usr/lib/hadoop/lib/*:/usr/lib/hadoop/:/usr/lib/hadoop/share/hadoop/hdfs/*:/usr/lib/hadoop/share/hadoop/mapreduce/*:/share/hadoop/mapreduce/*:/usr/lib/hadoop/share/hadoop/mapreduce/*:/usr/lib/hadoop/share/hadoop/mapreduce/lib/*:/etc/hadoop/conf/nm-config/log4j.properties org.apache.hadoop.yarn.server.nodemanager.NodeManager
      Unrecognized option: -jvm
      Could not create the Java virtual machine.
      

      The culprit is this bit of code that looks suspiciously like what used to be in bin/hdfs in support of jsvc launch:

      elif [ "$COMMAND" = "nodemanager" ] ; then
        CLASSPATH=${CLASSPATH}:$YARN_CONF_DIR/nm-config/log4j.properties
        CLASS='org.apache.hadoop.yarn.server.nodemanager.NodeManager'
        if [[ $EUID -eq 0 ]]; then
          YARN_OPTS="$YARN_OPTS -jvm server $YARN_NODEMANAGER_OPTS"
        else
          YARN_OPTS="$YARN_OPTS -server $YARN_NODEMANAGER_OPTS"
        fi
      
      1. MAPREDUCE-3879.patch.txt
        0.8 kB
        Roman Shaposhnik

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515053/MAPREDUCE-3879.patch.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1891//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1891//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515053/MAPREDUCE-3879.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1891//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1891//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        +1 (non-binding), the patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1 (non-binding), the patch looks good to me.
        Hide
        Devaraj K added a comment -

        Fixed with MAPREDUCE-3578.

        Show
        Devaraj K added a comment - Fixed with MAPREDUCE-3578 .
        Hide
        Devaraj K added a comment -
        Show
        Devaraj K added a comment - Dup of MAPREDUCE-3578 .

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development