Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3840

JobEndNotifier doesn't use the proxyToUse during connecting

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: mrv2
    • Labels:
      None

      Description

      I stupidly removed the proxyToUse from openConnection() in MAPREDUCE-3649.

        Activity

        Hide
        Ravi Prakash added a comment -

        Simple change

        Show
        Ravi Prakash added a comment - Simple change
        Hide
        Robert Joseph Evans added a comment -

        The patch looks reasonable to me, if it comes back from Jenkins OK I will +1 it. I can put it into 0.24 and 0.23.2, but if you want it in 0.23.1, which is in RC right now you are going to have to ping Arun about it.

        Show
        Robert Joseph Evans added a comment - The patch looks reasonable to me, if it comes back from Jenkins OK I will +1 it. I can put it into 0.24 and 0.23.2, but if you want it in 0.23.1, which is in RC right now you are going to have to ping Arun about it.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513830/MAPREDUCE-3840.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1825//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1825//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513830/MAPREDUCE-3840.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1825//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1825//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        Ravi, I just checked this into 0.23.2 and trunk. I am not resolving it yet, because 0.23.2 has not been added into JIRA yet, and you indicated that this should go into 0.23.1.

        Show
        Robert Joseph Evans added a comment - Ravi, I just checked this into 0.23.2 and trunk. I am not resolving it yet, because 0.23.2 has not been added into JIRA yet, and you indicated that this should go into 0.23.1.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1772 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1772/)
        MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby)

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1772 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1772/ ) MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #525 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/525/)
        svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #525 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/525/ ) svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1697 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1697/)
        MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby)

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1697 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1697/ ) MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #514 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/514/)
        svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #514 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/514/ ) svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1708 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1708/)
        MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby)

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1708 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1708/ ) MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #529 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/529/)
        svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #529 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/529/ ) svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #951 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/951/)
        MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby)

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #951 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/951/ ) MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #164 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/164/)
        svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #164 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/164/ ) svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/186/)
        svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/186/ ) svn merge -c 1241999 fixes MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242002 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #984 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/984/)
        MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby)

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #984 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/984/ ) MAPREDUCE-3840 JobEndNotifier doesn't use the proxyToUse during connecting (Ravi Prakash via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241999 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
        Hide
        Arun C Murthy added a comment -

        +1 for 23.1, I'm going to have to roll an RC1 anyway for HDFS-2923.

        Show
        Arun C Murthy added a comment - +1 for 23.1, I'm going to have to roll an RC1 anyway for HDFS-2923 .
        Hide
        Robert Joseph Evans added a comment -

        Thanks Ravi. I just committed this to 0.23.1 as well.

        Show
        Robert Joseph Evans added a comment - Thanks Ravi. I just committed this to 0.23.1 as well.

          People

          • Assignee:
            Ravi Prakash
            Reporter:
            Ravi Prakash
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development