Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-383

pipes combiner does not reset properly after a spill

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixed a bug in Pipes combiner to reset the spilled bytes count after the spill.

      Description

      When using a pipes combiner, the variable numBytes is not reset to 0 in spillAll, effectively reducing the effect of running a combiner to the first spill.

      1. patch.HADOOP-6070
        0.3 kB
        Christian Kunz

        Activity

        Hide
        Amareshwari Sriramadasu added a comment -

        changes look fine to me

        Show
        Amareshwari Sriramadasu added a comment - changes look fine to me
        Hide
        Amareshwari Sriramadasu added a comment -

        Christian, Did you test the patch? Can you post the test results?

        Show
        Amareshwari Sriramadasu added a comment - Christian, Did you test the patch? Can you post the test results?
        Hide
        Amareshwari Sriramadasu added a comment -

        canceling patch to add it to hudson queue

        Show
        Amareshwari Sriramadasu added a comment - canceling patch to add it to hudson queue
        Hide
        Christian Kunz added a comment -

        We ran the patch in our application environment and it worked fine. Not much more to say.

        Show
        Christian Kunz added a comment - We ran the patch in our application environment and it worked fine. Not much more to say.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12410966/patch.HADOOP-6070
        against trunk revision 792839.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410966/patch.HADOOP-6070 against trunk revision 792839. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/373/console This message is automatically generated.
        Hide
        Sharad Agarwal added a comment -

        I committed this to trunk and branch 0.20. Thanks Christian!

        Show
        Sharad Agarwal added a comment - I committed this to trunk and branch 0.20. Thanks Christian!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #31 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/31/)
        . Fix a bug in Pipes combiner due to bytes count not getting reset after the spill. Contributed by Christian Kunz.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #31 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/31/ ) . Fix a bug in Pipes combiner due to bytes count not getting reset after the spill. Contributed by Christian Kunz.

          People

          • Assignee:
            Christian Kunz
            Reporter:
            Christian Kunz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development