Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Patch that ports MultipleInputs, DelegatingInputFormat, DelegatingMapper and TaggedInputSplit to the new Map/Reduce API
      Show
      Patch that ports MultipleInputs, DelegatingInputFormat, DelegatingMapper and TaggedInputSplit to the new Map/Reduce API
    1. patch-369.txt
      29 kB
      Amareshwari Sriramadasu

      Activity

      Hide
      Amareshwari Sriramadasu added a comment -

      Patch deprecates org.apache.hadoop.mapred.lib.MultipleInputs, org.apache.hadoop.mapred.lib.DelegatingInputFormat, org.apache.hadoop.mapred.lib.DelegatingMapper and org.apache.hadoop.mapred.lib.TaggedInputSplit.
      Adds org.apache.hadoop.mapreduce.lib.input.MultipleInputs, org.apache.hadoop.mapreduce.lib.input.DelegatingInputFormat, org.apache.hadoop.mapreduce.lib.input.DelegatingMapper and org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit.

      Show
      Amareshwari Sriramadasu added a comment - Patch deprecates org.apache.hadoop.mapred.lib.MultipleInputs, org.apache.hadoop.mapred.lib.DelegatingInputFormat, org.apache.hadoop.mapred.lib.DelegatingMapper and org.apache.hadoop.mapred.lib.TaggedInputSplit. Adds org.apache.hadoop.mapreduce.lib.input.MultipleInputs, org.apache.hadoop.mapreduce.lib.input.DelegatingInputFormat, org.apache.hadoop.mapreduce.lib.input.DelegatingMapper and org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12413659/patch-369.txt
      against trunk revision 794637.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      -1 contrib tests. The patch failed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12413659/patch-369.txt against trunk revision 794637. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/404/console This message is automatically generated.
      Hide
      Sharad Agarwal added a comment -

      Patch looks good except that DelegatingMapper should be moved to org.apache.hadoop.mapreduce.lib.input.map package

      Show
      Sharad Agarwal added a comment - Patch looks good except that DelegatingMapper should be moved to org.apache.hadoop.mapreduce.lib.input.map package
      Hide
      Sharad Agarwal added a comment -

      On second thought, realized that all classes related to MultipleInputs should be part of same package, so its fine.

      Show
      Sharad Agarwal added a comment - On second thought, realized that all classes related to MultipleInputs should be part of same package, so its fine.
      Hide
      Sharad Agarwal added a comment -

      I just committed this. Thanks Amareshwari!

      Show
      Sharad Agarwal added a comment - I just committed this. Thanks Amareshwari!
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #33 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/33/)
      . Change org.apache.hadoop.mapred.lib.MultipleInputs to use new mapreduce API. Contributed by Amareshwari Sriramadasu.

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #33 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/33/ ) . Change org.apache.hadoop.mapred.lib.MultipleInputs to use new mapreduce API. Contributed by Amareshwari Sriramadasu.

        People

        • Assignee:
          Amareshwari Sriramadasu
          Reporter:
          Amareshwari Sriramadasu
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development