[MAPREDUCE-3556] Resource Leaks in key flows

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 0.23.0
• Assignee: Devaraj Kavali
• Reporter: Devaraj Kavali
• Created: 14/Dec/11 05:47
• Updated: 17/Jan/13 13:12
• Resolved: 17/Jan/13 13:12

Description

MapTask.java

 
 if (combinerRunner == null || numSpills < minSpillsForCombine) {
            Merger.writeFile(kvIter, writer, reporter, job);
          } else {
            combineCollector.setWriter(writer);
            combinerRunner.combine(kvIter, combineCollector);
          }

          //close
          writer.close();

InputSampler.java

 
 for(int i = 1; i < numPartitions; ++i) {
      int k = Math.round(stepSize * i);
      while (last >= k && comparator.compare(samples[last], samples[k]) == 0) {
        ++k;
      }
      writer.append(samples[k], nullValue);
      last = k;
    }
    writer.close();

The key flows have potential resource leaks.

JobSplitWriter.java

 

    SplitMetaInfo[] info = writeNewSplits(conf, splits, out);
    out.close();

    SplitMetaInfo[] info = writeOldSplits(splits, out);
    out.close();