Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.23.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      MapTask.java
      
      
       
       if (combinerRunner == null || numSpills < minSpillsForCombine) {
                  Merger.writeFile(kvIter, writer, reporter, job);
                } else {
                  combineCollector.setWriter(writer);
                  combinerRunner.combine(kvIter, combineCollector);
                }
      
                //close
                writer.close();
      
      InputSampler.java
      
      
       
       for(int i = 1; i < numPartitions; ++i) {
            int k = Math.round(stepSize * i);
            while (last >= k && comparator.compare(samples[last], samples[k]) == 0) {
              ++k;
            }
            writer.append(samples[k], nullValue);
            last = k;
          }
          writer.close();

      The key flows have potential resource leaks.

      JobSplitWriter.java
      
      
       
      
          SplitMetaInfo[] info = writeNewSplits(conf, splits, out);
          out.close();
      
          SplitMetaInfo[] info = writeOldSplits(splits, out);
          out.close();
      

        Activity

        Devaraj K created issue -
        Devaraj K made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-3556.patch [ 12507537 ]
        Hide
        Devaraj K added a comment -

        Attaching the patch with the fix.

        Show
        Devaraj K added a comment - Attaching the patch with the fix.
        Devaraj K made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12507537/MAPREDUCE-3556.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup
        org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1461//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1461//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507537/MAPREDUCE-3556.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1461//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1461//console This message is automatically generated.
        Devaraj K made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 9h 17m 1 Devaraj K 15/Dec/11 15:05
        Patch Available Patch Available Resolved Resolved
        398d 22h 7m 1 Devaraj K 17/Jan/13 13:12

          People

          • Assignee:
            Devaraj K
            Reporter:
            Devaraj K
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development