Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3540

saveVersion.sh script fails in windows/cygwin (hadoop-yarn-common)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: 0.24.0, trunk
    • Fix Version/s: 0.24.0
    • Component/s: build
    • Labels:
      None

      Description

      [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2:exec (generate-version) on project hadoop-yarn-common: Comman
      d execution failed. Cannot run program "scripts\saveVersion.sh" (in directory "C:\cygwin\home\tucu\src\hadoop\hadoop-mapreduce-proje
      ct\hadoop-yarn\hadoop-yarn-common"): CreateProcess error=2, The system cannot find the file specified -> [Help 1]
      [ERROR]
      
      1. MAPREDUCE-3540.Nov12.patch
        1 kB
        Mostafa Elhemali
      2. MAPREDUCE-3540.patch
        2 kB
        Mostafa Elhemali
      3. MAPREDUCE-3540-121001.patch
        0.8 kB
        Trevor Robinson

        Issue Links

          Activity

          Hide
          Ivan Mitic added a comment -

          This Jira seems outdated now that Hadoop can be compiled on Windows without Cygwin. Should we resolve this Jira?

          Show
          Ivan Mitic added a comment - This Jira seems outdated now that Hadoop can be compiled on Windows without Cygwin. Should we resolve this Jira?
          Hide
          Ivan Mitic added a comment -

          Hi Anoop, you no longer need to run from Cygwin shell to be able to compile and run Hadoop on Windows (this is post HADOOP-8562 merge). Check BUILDING.txt for instructions on how to compile natively on Windows.

          Show
          Ivan Mitic added a comment - Hi Anoop, you no longer need to run from Cygwin shell to be able to compile and run Hadoop on Windows (this is post HADOOP-8562 merge). Check BUILDING.txt for instructions on how to compile natively on Windows.
          Hide
          Anoop Sam John added a comment -

          The patch worked for me as well. Can some committers have a look at it pls?

          Show
          Anoop Sam John added a comment - The patch worked for me as well. Can some committers have a look at it pls?
          Hide
          Trevor Robinson added a comment -

          Yes, if you use the Windows whoami, it has a newline at the end. A workaround is to put the Cygwin bin directory before Windows\System32 in your PATH, but it's helpful to include that in this fix.

          Show
          Trevor Robinson added a comment - Yes, if you use the Windows whoami , it has a newline at the end. A workaround is to put the Cygwin bin directory before Windows\System32 in your PATH , but it's helpful to include that in this fix.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554748/MAPREDUCE-3540.Nov12.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3063//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3063//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554748/MAPREDUCE-3540.Nov12.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3063//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3063//console This message is automatically generated.
          Hide
          Mostafa Elhemali added a comment -

          Thanks Trevor for updating the patch. I still needed to trim newlines from whoami in my environment for build to work so including an updated patch with that fix intact (and unnecessary whitespace changes removed).

          Show
          Mostafa Elhemali added a comment - Thanks Trevor for updating the patch. I still needed to trim newlines from whoami in my environment for build to work so including an updated patch with that fix intact (and unnecessary whitespace changes removed).
          Hide
          Trevor Robinson added a comment -

          Will someone please review and commit this patch? It's a super minor issue, but super annoying.

          Show
          Trevor Robinson added a comment - Will someone please review and commit this patch? It's a super minor issue, but super annoying.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12547267/MAPREDUCE-3540-121001.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2898//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2898//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547267/MAPREDUCE-3540-121001.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2898//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2898//console This message is automatically generated.
          Hide
          Trevor Robinson added a comment -

          Updated patch now that YARN is no longer under hadoop-mapreduce-project. Also no longer includes unnecessary whitespace changes.

          Show
          Trevor Robinson added a comment - Updated patch now that YARN is no longer under hadoop-mapreduce-project. Also no longer includes unnecessary whitespace changes.
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Alejandro, Could you please take a look for committ?

          In windows environment, always it fails due to this problem.

          Show
          Uma Maheswara Rao G added a comment - Hi Alejandro, Could you please take a look for committ? In windows environment, always it fails due to this problem.
          Hide
          xieguiming added a comment -

          This patch also works my windows env.
          Thanks for the patch.

          Show
          xieguiming added a comment - This patch also works my windows env. Thanks for the patch.
          Hide
          Wu Wei added a comment -

          +1 for this patch.

          It works on my windows environment (using cygwin).

          Show
          Wu Wei added a comment - +1 for this patch. It works on my windows environment (using cygwin).
          Hide
          Mostafa Elhemali added a comment -

          There is a version there but it outputs the CR/LF. Note that this is a copy-paste of the same workaround in hadoop-common-project/hadoop-common/dev-support/saveVersion.sh

          Show
          Mostafa Elhemali added a comment - There is a version there but it outputs the CR/LF. Note that this is a copy-paste of the same workaround in hadoop-common-project/hadoop-common/dev-support/saveVersion.sh
          Hide
          Bikas Saha added a comment -

          Is the unix version of whoami not available on Cygwin? Looks like you are trying to convert the Windows whoami CR/LF to Unix.

          Show
          Bikas Saha added a comment - Is the unix version of whoami not available on Cygwin? Looks like you are trying to convert the Windows whoami CR/LF to Unix.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519673/MAPREDUCE-3540.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2093//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2093//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519673/MAPREDUCE-3540.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2093//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2093//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519665/MAPREDUCE-3540.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2092//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519665/MAPREDUCE-3540.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2092//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519646/MAPREDUCE-3540.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2090//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519646/MAPREDUCE-3540.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2090//console This message is automatically generated.
          Hide
          Mostafa Elhemali added a comment -

          Fixes the Hadoop build on Windows.

          Show
          Mostafa Elhemali added a comment - Fixes the Hadoop build on Windows.

            People

            • Assignee:
              Unassigned
              Reporter:
              Alejandro Abdelnur
            • Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development