Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: 0.20.2, 0.21.0, 1.0.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      in DistCh.java

      in setup method
      opWriter.close();
      if opWriter is null then if we will try to close will throw NPE.
      
      in checkDuplication method
      in.close();
      if in is null then if we will try to close will throw NPE.
      
      1. MAPREDUCE-3539.patch
        0.9 kB
        kavita sharma
      2. MAPREDUCE-3539-branch-1.patch
        0.9 kB
        kavita sharma

        Activity

        Hide
        kavita sharma added a comment -

        Hi,
        No testcase is present because for closing streams i have used IOUtils that is a exiting and tested utility.

        Thanks
        Kavita Sharma

        Show
        kavita sharma added a comment - Hi, No testcase is present because for closing streams i have used IOUtils that is a exiting and tested utility. Thanks Kavita Sharma
        Hide
        kavita sharma added a comment -

        Hi,
        No testcase is present because for closing streams i have used IOUtils that is a exiting and tested utility.

        Thanks
        Kavita

        Show
        kavita sharma added a comment - Hi, No testcase is present because for closing streams i have used IOUtils that is a exiting and tested utility. Thanks Kavita
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12507870/MAPREDUCE-3539-branch-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1476//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1476//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507870/MAPREDUCE-3539-branch-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1476//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1476//console This message is automatically generated.
        Hide
        Matt Foley added a comment -

        No commits have been made, but 1.0.0 has been released. Moving the target versions from "Fixed Version" to "Target Version" field, and changing to 1.1.0.

        Show
        Matt Foley added a comment - No commits have been made, but 1.0.0 has been released. Moving the target versions from "Fixed Version" to "Target Version" field, and changing to 1.1.0.
        Hide
        kavita sharma added a comment -

        Hi Matt,
        No testcase is present because for closing streams i have used IOUtils.cleanup that is a existing and tested utility.

        Show
        kavita sharma added a comment - Hi Matt, No testcase is present because for closing streams i have used IOUtils.cleanup that is a existing and tested utility.
        Hide
        Matt Foley added a comment -

        Moved to 1.2.0 upon release of 1.1.0.

        Show
        Matt Foley added a comment - Moved to 1.2.0 upon release of 1.1.0.
        Hide
        Matt Foley added a comment -

        Changed Target Version to 1.3.0 upon release of 1.2.0. Please change to 1.2.1 if you intend to submit a fix for branch-1.2.

        Show
        Matt Foley added a comment - Changed Target Version to 1.3.0 upon release of 1.2.0. Please change to 1.2.1 if you intend to submit a fix for branch-1.2.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12507870/MAPREDUCE-3539-branch-1.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4523//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507870/MAPREDUCE-3539-branch-1.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4523//console This message is automatically generated.

          People

          • Assignee:
            Unassigned
            Reporter:
            kavita sharma
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development