Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3317

Rumen TraceBuilder is emiting null as hostname

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: tools/rumen
    • Labels:
      None
    • Target Version/s:
    • Release Note:
      Fixes Rumen to get correct hostName that includes rackName in attempt info.

      Description

      Trace generated by Rumen TraceBuilder contains null as hostname even though hostName and rackName are seen in history file. This is after MAPREDUCE-3035.

      1. 3317.patch
        1 kB
        Ravi Gummadi

        Issue Links

          Activity

          Ravi Gummadi created issue -
          Ravi Gummadi made changes -
          Field Original Value New Value
          Assignee Amar Kamat [ amar_kamat ]
          Ravi Gummadi made changes -
          Affects Version/s 0.23.0 [ 12315570 ]
          Ravi Gummadi made changes -
          Link This issue is related to MAPREDUCE-3035 [ MAPREDUCE-3035 ]
          Ravi Gummadi made changes -
          Assignee Amar Kamat [ amar_kamat ] Ravi Gummadi [ ravidotg ]
          Hide
          Ravi Gummadi added a comment -

          LoggedTaskAttempt.setHostName() has a minor bug. It is checking if this.rackName is null or not instead of checking the parameter rackName.

          Show
          Ravi Gummadi added a comment - LoggedTaskAttempt.setHostName() has a minor bug. It is checking if this.rackName is null or not instead of checking the parameter rackName.
          Hide
          Ravi Gummadi added a comment -

          Attaching patch with trivial fix.

          Also changed the format of hostName to rackName/hostName instead of hostName/rackName. This is to match the format seen in earlier/old trace files.

          Show
          Ravi Gummadi added a comment - Attaching patch with trivial fix. Also changed the format of hostName to rackName/hostName instead of hostName/rackName. This is to match the format seen in earlier/old trace files.
          Ravi Gummadi made changes -
          Attachment 3317.patch [ 12501727 ]
          Ravi Gummadi made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note Fixes Rumen to get correct hostName that includes rackName in attempt info.
          Target Version/s 0.23.0 [ 12315570 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501727/3317.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1232//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1232//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501727/3317.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1232//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1232//console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          +1, committing this to 0.23 and trunk

          Show
          Mahadev konar added a comment - +1, committing this to 0.23 and trunk
          Hide
          Mahadev konar added a comment -

          I just committed this. Thanks Ravi.

          Show
          Mahadev konar added a comment - I just committed this. Thanks Ravi.
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.23.0 [ 12315570 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1243 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1243/)
          MAPREDUCE-3317. Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1243 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1243/ ) MAPREDUCE-3317 . Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #133 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/133/)
          MAPREDUCE-3317. Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev) - Merging r1195814 from trunk.

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195815
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #133 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/133/ ) MAPREDUCE-3317 . Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev) - Merging r1195814 from trunk. mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195815 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1220 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1220/)
          MAPREDUCE-3317. Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1220 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1220/ ) MAPREDUCE-3317 . Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1296 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1296/)
          MAPREDUCE-3317. Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1296 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1296/ ) MAPREDUCE-3317 . Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #850 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/850/)
          MAPREDUCE-3317. Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #850 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/850/ ) MAPREDUCE-3317 . Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Hide
          Amar Kamat added a comment -

          What should be the expected output if either hostname or rackname is null? We should make sure that Rumen's output is consistent and should match the previous version.

          Show
          Amar Kamat added a comment - What should be the expected output if either hostname or rackname is null? We should make sure that Rumen's output is consistent and should match the previous version.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #884 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/884/)
          MAPREDUCE-3317. Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #884 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/884/ ) MAPREDUCE-3317 . Rumen TraceBuilder is emiting null as hostname. (Ravi Gummadi via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195814 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/tools/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          9h 43m 1 Ravi Gummadi 01/Nov/11 03:32
          Patch Available Patch Available Resolved Resolved
          1h 1m 1 Mahadev konar 01/Nov/11 04:33
          Resolved Resolved Closed Closed
          13d 20h 15m 1 Arun C Murthy 15/Nov/11 00:49

            People

            • Assignee:
              Ravi Gummadi
              Reporter:
              Ravi Gummadi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development