Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup.
      Show
      Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup.

      Description

      Testcase: testNoJobSetupCleanup took 13.271 sec
      FAILED
      Number of part-files is 0 and not 1
      junit.framework.AssertionFailedError: Number of part-files is 0 and not 1
      at org.apache.hadoop.mapreduce.TestNoJobSetupCleanup.submitAndValidateJob(TestNoJobSetupCleanup.java:60)
      at org.apache.hadoop.mapreduce.TestNoJobSetupCleanup.testNoJobSetupCleanup(TestNoJobSetupCleanup.java:70)

        Activity

        Hide
        Hitesh Shah added a comment -

        @Devaraj, if you have not already started working on this, I can take this up.

        Show
        Hitesh Shah added a comment - @Devaraj, if you have not already started working on this, I can take this up.
        Hide
        Hitesh Shah added a comment -

        The failure is due to commit job not being called.

        Show
        Hitesh Shah added a comment - The failure is due to commit job not being called.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12501993/MR-3215.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1242//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1242//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501993/MR-3215.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1242//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1242//console This message is automatically generated.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Test with the commented out code reenabled fails without the patch, and passes with the patch.

        Patch looks good too. +1.

        I think we should deprecate the setJobSetupCleanupNeeded() API. Before 0.23, we could disable set up and cleanup, yet obtain the output when using FileOutputCommitter in the job-output directory. But post 0.23.0, that won't be the case because of the nested temporary directories to support AM recoverability. Will open a separate ticket.

        Show
        Vinod Kumar Vavilapalli added a comment - Test with the commented out code reenabled fails without the patch, and passes with the patch. Patch looks good too. +1. I think we should deprecate the setJobSetupCleanupNeeded() API. Before 0.23, we could disable set up and cleanup, yet obtain the output when using FileOutputCommitter in the job-output directory. But post 0.23.0, that won't be the case because of the nested temporary directories to support AM recoverability. Will open a separate ticket.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        I just committed this to trunk and branch-0.23. Thanks Hitesh!

        Show
        Vinod Kumar Vavilapalli added a comment - I just committed this to trunk and branch-0.23. Thanks Hitesh!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1244 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1244/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1244 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1244/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1318 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1318/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1318 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1318/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #146 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/146/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.
        svn merge -c r1197101 --ignore-ancestry ../../trunk/

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #146 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/146/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. svn merge -c r1197101 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #145 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/145/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.
        svn merge -c r1197101 --ignore-ancestry ../../trunk/

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #145 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/145/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. svn merge -c r1197101 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1266 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1266/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1266 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1266/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #157 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/157/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.
        svn merge -c r1197101 --ignore-ancestry ../../trunk/

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #157 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/157/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. svn merge -c r1197101 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #66 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/66/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.
        svn merge -c r1197101 --ignore-ancestry ../../trunk/

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #66 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/66/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. svn merge -c r1197101 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #853 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/853/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #853 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/853/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #80 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/80/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.
        svn merge -c r1197101 --ignore-ancestry ../../trunk/

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #80 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/80/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. svn merge -c r1197101 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197102 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #887 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/887/)
        MAPREDUCE-3215. Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #887 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/887/ ) MAPREDUCE-3215 . Reneabled and fixed bugs in the failing test TestNoJobSetupCleanup. Contributed by Hitesh Shah. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197101 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/TestNoJobSetupCleanup.java

          People

          • Assignee:
            Hitesh Shah
            Reporter:
            Hitesh Shah
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development