Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3023

Queue state is not being translated properly (is always assumed to be running)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: mrv2
    • Labels:
      None

      Description

      During translation of QueueInfo,

      TypeConverter.java:435 : queueInfo.toString(), QueueState.RUNNING,

      ought to be

      queueInfo.toString(), QueueState.getState(queueInfo.getQueueState().toString().toLowerCase()),

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #807 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/807/)
        MAPREDUCE-3023. Fixed clients to display queue state correctly. Contributed by Ravi Prakash.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #807 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/807/ ) MAPREDUCE-3023 . Fixed clients to display queue state correctly. Contributed by Ravi Prakash. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #837 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/837/)
        MAPREDUCE-3023. Fixed clients to display queue state correctly. Contributed by Ravi Prakash.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #837 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/837/ ) MAPREDUCE-3023 . Fixed clients to display queue state correctly. Contributed by Ravi Prakash. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #16 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/16/)
        Merge -r 1173457:1173458 from trunk to branch-0.23 to fix MAPREDUCE-3023.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173460
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #16 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/16/ ) Merge -r 1173457:1173458 from trunk to branch-0.23 to fix MAPREDUCE-3023 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173460 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #17 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/17/)
        Merge -r 1173457:1173458 from trunk to branch-0.23 to fix MAPREDUCE-3023.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173460
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #17 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/17/ ) Merge -r 1173457:1173458 from trunk to branch-0.23 to fix MAPREDUCE-3023 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173460 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/942/)
        MAPREDUCE-3023. Fixed clients to display queue state correctly. Contributed by Ravi Prakash.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/942/ ) MAPREDUCE-3023 . Fixed clients to display queue state correctly. Contributed by Ravi Prakash. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Hide
        Ravi Prakash added a comment -

        Thanks Arun!

        Show
        Ravi Prakash added a comment - Thanks Arun!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1003 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1003/)
        MAPREDUCE-3023. Fixed clients to display queue state correctly. Contributed by Ravi Prakash.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1003 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1003/ ) MAPREDUCE-3023 . Fixed clients to display queue state correctly. Contributed by Ravi Prakash. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #925 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/925/)
        MAPREDUCE-3023. Fixed clients to display queue state correctly. Contributed by Ravi Prakash.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #925 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/925/ ) MAPREDUCE-3023 . Fixed clients to display queue state correctly. Contributed by Ravi Prakash. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173458 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks Ravi!

        Show
        Arun C Murthy added a comment - I just committed this. Thanks Ravi!
        Hide
        Arun C Murthy added a comment -

        +1 looks good.

        In general, we should avoid references to yarn apis in hadoop-mapreduce-client-core...

        Show
        Arun C Murthy added a comment - +1 looks good. In general, we should avoid references to yarn apis in hadoop-mapreduce-client-core...
        Hide
        Ravi Prakash added a comment -

        @Arun: Thanks for the great suggestion! I've made the change! Uploaded patch.

        Show
        Ravi Prakash added a comment - @Arun: Thanks for the great suggestion! I've made the change! Uploaded patch.
        Hide
        Arun C Murthy added a comment -

        Ravi - the patch looks good.

        One nit - do the conversion from org.apache.hadoop.yarn.api.records.QueueState to org.apache.hadoop.mapreduce.QueueState in TypeConvertor, not in org.apache.hadoop.mapreduce.QueueState.

        Show
        Arun C Murthy added a comment - Ravi - the patch looks good. One nit - do the conversion from org.apache.hadoop.yarn.api.records.QueueState to org.apache.hadoop.mapreduce.QueueState in TypeConvertor, not in org.apache.hadoop.mapreduce.QueueState.
        Hide
        Ravi Prakash added a comment -

        The exact same patch also applies to trunk.

        Show
        Ravi Prakash added a comment - The exact same patch also applies to trunk.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494857/MAPREDUCE-3023.branch-0.23.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/770//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/770//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494857/MAPREDUCE-3023.branch-0.23.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/770//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/770//console This message is automatically generated.
        Hide
        Ravi Prakash added a comment -

        I changed my mind. Now org.apache.hadoop.mapreduce.QueueState has a public static method which accepts org.apache.hadoop.yarn.api.records.QueueState

        Please review and commit

        Show
        Ravi Prakash added a comment - I changed my mind. Now org.apache.hadoop.mapreduce.QueueState has a public static method which accepts org.apache.hadoop.yarn.api.records.QueueState Please review and commit

          People

          • Assignee:
            Ravi Prakash
            Reporter:
            Ravi Prakash
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development