Thanks for the review. Should really have split the patch.
JobHistoryServer: commented out lines about mapred-site.xml
Removed instead of commenting.
TestHSWebApp.testLogView2: Error message can be improved.
ContainerManagerImpl.handle(): Why special handling of log-finish event. Can't use ContainerManagerEvent?
Done via a CMgrEvent.
AMStartedEvent.java : constructor >80 chars
AggregatedLogsBlock: No need for creating ApplicationACLsManager every single time?
The history service currently does not have an AppAclManager. Can we leave this like this for now, and fix it later when the HistoryService adds it.
Added a flag to disable aggregation (defaults to disabled)
Could add offsets etc. for aggregated logs
Will do this after revising the log storage format to make types easier to find.
Changes similar to HSJobBlock needed for JobBlock listing all AppAttempts so far.
That could be done - display all previous AM logs on the current AM UI.
Passing usernames explicitly is unweildly.
Agreed, it's just a hint as to where to look for the logs. At least ACL checks are done correctly after this.