Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2984

Throwing NullPointerException when we open the container page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: mrv2, nodemanager
    • Labels:
      None

      Description

      Caused by: java.lang.NullPointerException
      	at org.apache.hadoop.yarn.api.records.ContainerId.compareTo(ContainerId.java:97)
      	at org.apache.hadoop.yarn.api.records.ContainerId.compareTo(ContainerId.java:23)
      	at java.util.concurrent.ConcurrentSkipListMap.doGet(ConcurrentSkipListMap.java:819)
      	at java.util.concurrent.ConcurrentSkipListMap.get(ConcurrentSkipListMap.java:1640)
      	at org.apache.hadoop.yarn.server.nodemanager.webapp.ContainerPage$ContainerBlock.render(ContainerPage.java:70)
      	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:64)
      	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:74)
      	at org.apache.hadoop.yarn.webapp.View.render(View.java:210)
      
      Caused by: java.lang.NullPointerException
      	at org.apache.hadoop.yarn.server.nodemanager.webapp.ContainerPage$ContainerBlock.render(ContainerPage.java:71)
      	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:64)
      	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:74)
      	at org.apache.hadoop.yarn.webapp.View.render(View.java:210)
      	at org.apache.hadoop.yarn.webapp.view.HtmlPage$Page.subView(HtmlPage.java:47)
      	at org.apache.hadoop.yarn.webapp.hamlet.HamletImpl$EImp._v(HamletImpl.java:117)
      	at org.apache.hadoop.yarn.webapp.hamlet.Hamlet$TD._(Hamlet.java:843)
      	at org.apache.hadoop.yarn.webapp.view.TwoColumnLayout.render(TwoColumnLayout.java:54)
      	at org.apache.hadoop.yarn.webapp.view.HtmlPage.render(HtmlPage.java:80)
      	at org.apache.hadoop.yarn.webapp.Controller.render(Controller.java:210)
      	at org.apache.hadoop.yarn.server.nodemanager.webapp.NMController.container(NMController.java:62)
      	... 30 more
      
      1. MAPREDUCE-2984-1.patch
        2 kB
        Devaraj K
      2. MAPREDUCE-2984.patch
        2 kB
        Devaraj K

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #843 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/843/)
        MAPREDUCE-2984. Better error message for displaying completed containers. Contributed by Devaraj K.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #843 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/843/ ) MAPREDUCE-2984 . Better error message for displaying completed containers. Contributed by Devaraj K. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #813 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/813/)
        MAPREDUCE-2984. Better error message for displaying completed containers. Contributed by Devaraj K.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #813 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/813/ ) MAPREDUCE-2984 . Better error message for displaying completed containers. Contributed by Devaraj K. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #22 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/22/)
        Merge -r 1176044:1176045 from trunk to branch-0.23 to fix MAPREDUCE-2984.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176046
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #22 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/22/ ) Merge -r 1176044:1176045 from trunk to branch-0.23 to fix MAPREDUCE-2984 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176046 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #28 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/28/)
        Merge -r 1176044:1176045 from trunk to branch-0.23 to fix MAPREDUCE-2984.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176046
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #28 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/28/ ) Merge -r 1176044:1176045 from trunk to branch-0.23 to fix MAPREDUCE-2984 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176046 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #975 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/975/)
        MAPREDUCE-2984. Better error message for displaying completed containers. Contributed by Devaraj K.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #975 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/975/ ) MAPREDUCE-2984 . Better error message for displaying completed containers. Contributed by Devaraj K. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1035/)
        MAPREDUCE-2984. Better error message for displaying completed containers. Contributed by Devaraj K.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1035/ ) MAPREDUCE-2984 . Better error message for displaying completed containers. Contributed by Devaraj K. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #957 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/957/)
        MAPREDUCE-2984. Better error message for displaying completed containers. Contributed by Devaraj K.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #957 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/957/ ) MAPREDUCE-2984 . Better error message for displaying completed containers. Contributed by Devaraj K. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176045 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerPage.java
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks Devaraj!

        Show
        Arun C Murthy added a comment - I just committed this. Thanks Devaraj!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12496463/MAPREDUCE-2984-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/858//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/858//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12496463/MAPREDUCE-2984-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/858//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/858//console This message is automatically generated.
        Hide
        Devaraj K added a comment -

        Updated the message as per Arun suggestion.

        Show
        Devaraj K added a comment - Updated the message as per Arun suggestion.
        Hide
        Arun C Murthy added a comment -

        The real cause is that the container has completed before we can display it's page?

        If so, can we just display a message such as: 'Unknown Container. Container might have completed, please go back to the previous page and retry.'

        Show
        Arun C Murthy added a comment - The real cause is that the container has completed before we can display it's page? If so, can we just display a message such as: 'Unknown Container. Container might have completed, please go back to the previous page and retry.'
        Hide
        Arun C Murthy added a comment -

        The real cause is that the container has completed before we can display it's page?

        Show
        Arun C Murthy added a comment - The real cause is that the container has completed before we can display it's page?
        Hide
        Devaraj K added a comment -

        It is straightforward scenario and doesn't need any tests.

        Verified it manually, after applying the patch it displays message "Unknown container. Container is either not yet running or has already completed or doesn't belong to this node at all." instead of causing it to NPE.

        Show
        Devaraj K added a comment - It is straightforward scenario and doesn't need any tests. Verified it manually, after applying the patch it displays message "Unknown container. Container is either not yet running or has already completed or doesn't belong to this node at all." instead of causing it to NPE.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12495212/MAPREDUCE-2984.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/799//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/799//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495212/MAPREDUCE-2984.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/799//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/799//console This message is automatically generated.
        Hide
        Devaraj K added a comment -

        Issue 1 is not coming in the latest trunk code.

        For issue 2,
        when the container is null displaying the message saying "Unknown container. Container is either not yet running or has already completed or doesn't belong to this node at all." instead of causing it to NPE.

        Show
        Devaraj K added a comment - Issue 1 is not coming in the latest trunk code. For issue 2, when the container is null displaying the message saying "Unknown container. Container is either not yet running or has already completed or doesn't belong to this node at all." instead of causing it to NPE.

          People

          • Assignee:
            Devaraj K
            Reporter:
            Devaraj K
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development