Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2944

Improve checking of input for Api displayTasks()

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 3.0.0
    • Component/s: client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The JobClient.displayTasks() will do nothing and won't throw any exception either,
      while user call it with invalid type/state of task.
      To be more friendly,it's better to remain user to check his parameters with an exception.

      1. MAPREDUCE-2944_v0.2.patch
        2 kB
        XieXianshan
      2. MAPREDUCE-2944_v0.3.patch
        3 kB
        XieXianshan
      3. MAPREDUCE-2944.patch
        4 kB
        Harsh J
      4. MAPREDUCE-2944.patch
        1 kB
        XieXianshan

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12493299/MAPREDUCE-2944.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493299/MAPREDUCE-2944.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/625//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        Hey Xie,

        Good catch. Patch is OK, but I have a few nitpicky comments:

        • Use a set of types and states instead? Would appear much cleaner
        • The exception message can also carry something like "Valid types are: X,Y,Z". This'd be immensely helpful to the developer doing it wrong (Its already covered by javadocs though).
        Show
        Harsh J added a comment - Hey Xie, Good catch. Patch is OK, but I have a few nitpicky comments: Use a set of types and states instead? Would appear much cleaner The exception message can also carry something like "Valid types are: X,Y,Z". This'd be immensely helpful to the developer doing it wrong (Its already covered by javadocs though).
        Hide
        XieXianshan added a comment -

        Thanks for your comment,@Harsh.
        I reuploaded the patch according to your comments.
        Please review it again,thanks in advance.

        Show
        XieXianshan added a comment - Thanks for your comment,@Harsh. I reuploaded the patch according to your comments. Please review it again,thanks in advance.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508724/MAPREDUCE-2944_v0.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1511//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1511//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508724/MAPREDUCE-2944_v0.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1511//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1511//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        Xie,

        Sorry for much back and forth, I should've read up more on the method itself before:

        • Lets use IllegalArgumentExceptions instead of IO ones. Its more appropriate.
        • I noted that the method called internally is the CLI's displayTasks() one. Perhaps we can add validation to that itself, and benefit both the API and the CLI.
        • The sets can be class' field members, no need to initialize them every time the method is called. Given the first point, in the super.displayTasks() method you only need to add in a set for the type of tasks, and an else clause to the state check there will cover the states validation.
        • Do update javadoc on @throws IllegalArgumentException stuff wherever applicable.
        Show
        Harsh J added a comment - Xie, Sorry for much back and forth, I should've read up more on the method itself before: Lets use IllegalArgumentExceptions instead of IO ones. Its more appropriate. I noted that the method called internally is the CLI's displayTasks() one. Perhaps we can add validation to that itself, and benefit both the API and the CLI. The sets can be class' field members, no need to initialize them every time the method is called. Given the first point, in the super.displayTasks() method you only need to add in a set for the type of tasks, and an else clause to the state check there will cover the states validation. Do update javadoc on @throws IllegalArgumentException stuff wherever applicable.
        Hide
        XieXianshan added a comment -

        Hi,Harsh,Thanks so much for your patience and your suggestions.
        I agree with you almost all of what you say except one little point:

        an else clause to the state check there will cover the states validation.

        There's a logical AND operation in the if clause in the CLI's displayTasks():

        if ((state.equals("pending") && status ==TIPStatus.PENDING) ||
                  (state.equals("running") && status ==TIPStatus.RUNNING) ||
                  (state.equals("completed") && status == TIPStatus.COMPLETE) ||
                  (state.equals("failed") && status == TIPStatus.FAILED) ||
                  (state.equals("killed") && status == TIPStatus.KILLED)) {
                printTaskAttempts(report);
              }
        

        So,we can't add validation of states in the else clause (eg. if-clause would also be FALSE if status != TIPStatus.PENDING, even though the state is equal to "pending").
        Maybe i misunderstood your meaning.

        Show
        XieXianshan added a comment - Hi,Harsh,Thanks so much for your patience and your suggestions. I agree with you almost all of what you say except one little point: an else clause to the state check there will cover the states validation. There's a logical AND operation in the if clause in the CLI's displayTasks(): if ((state.equals( "pending" ) && status ==TIPStatus.PENDING) || (state.equals( "running" ) && status ==TIPStatus.RUNNING) || (state.equals( "completed" ) && status == TIPStatus.COMPLETE) || (state.equals( "failed" ) && status == TIPStatus.FAILED) || (state.equals( "killed" ) && status == TIPStatus.KILLED)) { printTaskAttempts(report); } So,we can't add validation of states in the else clause (eg. if-clause would also be FALSE if status != TIPStatus.PENDING, even though the state is equal to "pending"). Maybe i misunderstood your meaning.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508744/MAPREDUCE-2944_v0.3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1515//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1515//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508744/MAPREDUCE-2944_v0.3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1515//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1515//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        Yeah you're right, I only just scanned over that – Please do as necessary!

        Show
        Harsh J added a comment - Yeah you're right, I only just scanned over that – Please do as necessary!
        Hide
        Harsh J added a comment -

        +1 on most recent patch. I just made some superficial changes (uploaded). Committing.

        Stuff I mainly changed was to remove newlines from exception messages. We should never do that as it messes the logs and stuff that would look for exceptions and stack traces. One long line of message is fine, lets always follow that ahead

        That + some doc message fixes to look a bit more clear.

        Show
        Harsh J added a comment - +1 on most recent patch. I just made some superficial changes (uploaded). Committing. Stuff I mainly changed was to remove newlines from exception messages. We should never do that as it messes the logs and stuff that would look for exceptions and stack traces. One long line of message is fine, lets always follow that ahead That + some doc message fixes to look a bit more clear.
        Hide
        Harsh J added a comment -

        Committed to trunk as r1225188. Many thanks for your improvements and contributions Xie!

        Show
        Harsh J added a comment - Committed to trunk as r1225188. Many thanks for your improvements and contributions Xie!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508757/MAPREDUCE-2944.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1516//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508757/MAPREDUCE-2944.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1516//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1545 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1545/)
        MAPREDUCE-2944. Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1545 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1545/ ) MAPREDUCE-2944 . Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1473 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1473/)
        MAPREDUCE-2944. Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1473 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1473/ ) MAPREDUCE-2944 . Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1494 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1494/)
        MAPREDUCE-2944. Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1494 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1494/ ) MAPREDUCE-2944 . Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #909 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/909/)
        MAPREDUCE-2944. Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #909 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/909/ ) MAPREDUCE-2944 . Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/942/)
        MAPREDUCE-2944. Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/942/ ) MAPREDUCE-2944 . Improve checking of input for JobClient.displayTasks() (XieXianshan via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225188 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        Hide
        Eli Collins added a comment -

        Harsh, Xie,

        1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.

        2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.

        Show
        Eli Collins added a comment - Harsh, Xie, 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
        Hide
        Thomas Graves added a comment -

        Was there a reason this didn't go into branch-2?

        Show
        Thomas Graves added a comment - Was there a reason this didn't go into branch-2?

          People

          • Assignee:
            XieXianshan
            Reporter:
            XieXianshan
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development