Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: contrib/raid, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Due to the changes in HDFS-2239, the following files cannot be compiled (Thanks Amar for pointing them out.)
      1. src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java
      2. src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java
      3. src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
      4. src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java

      1. m2797_20110810.patch
        5 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Description Due to the changes in HDFS-2239, the following files cannot be compiled (Thanks Uma for pointing them out.)
          1. src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java
          2. src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java
          3. src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          4. src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java
          Due to the changes in HDFS-2239, the following files cannot be compiled (Thanks Amar for pointing them out.)
          1. src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java
          2. src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java
          3. src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          4. src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java
          Hide
          Tsz Wo Nicholas Sze added a comment -

          m2797_20110810.patch: fix compilation problems.

          Show
          Tsz Wo Nicholas Sze added a comment - m2797_20110810.patch: fix compilation problems.
          Tsz Wo Nicholas Sze made changes -
          Attachment m2797_20110810.patch [ 12489983 ]
          Tsz Wo Nicholas Sze made changes -
          Assignee Tsz Wo (Nicholas), SZE [ szetszwo ]
          Component/s contrib/raid [ 12313416 ]
          Component/s test [ 12312904 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I checked it manually. The patch fixed the problems. Will commit it temporarily, otherwise, mapreduce cannot be compiled.

          Show
          Tsz Wo Nicholas Sze added a comment - I checked it manually. The patch fixed the problems. Will commit it temporarily, otherwise, mapreduce cannot be compiled.
          Tsz Wo Nicholas Sze made changes -
          Link This issue is broken by HDFS-2239 [ HDFS-2239 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #720 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/720/)
          MAPREDUCE-2797. Update mapreduce tests and RAID for HDFS-2239.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156215
          Files :

          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #720 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/720/ ) MAPREDUCE-2797 . Update mapreduce tests and RAID for HDFS-2239 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156215 Files : /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          Hide
          Aaron T. Myers added a comment -

          +1, the patch looks good to me.

          Show
          Aaron T. Myers added a comment - +1, the patch looks good to me.
          Aaron T. Myers made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Reviewed]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Aaron, thanks for the review.

          Resolving this.

          Show
          Tsz Wo Nicholas Sze added a comment - Aaron, thanks for the review. Resolving this.
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.23.0 [ 12315570 ]
          Resolution Fixed [ 1 ]
          Hide
          Amar Kamat added a comment -

          Thanks Nichols for the quick attention.

          Show
          Amar Kamat added a comment - Thanks Nichols for the quick attention.
          Hide
          Amar Kamat added a comment -

          Nicholas,
          I still see 'src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/datanode/RaidBlockSender.java' failing to compile. The error message is as follows

          src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/datanode/RaidBlockSender.java:44: interface expected here
              [javac] public class RaidBlockSender implements java.io.Closeable, FSConstants {
              [javac]                                                            ^
          
          Show
          Amar Kamat added a comment - Nicholas, I still see 'src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/datanode/RaidBlockSender.java' failing to compile. The error message is as follows src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/datanode/RaidBlockSender.java:44: interface expected here [javac] public class RaidBlockSender implements java.io.Closeable, FSConstants { [javac] ^
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Amar, this is related to HDFS-2241. Let me file a JIRA.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Amar, this is related to HDFS-2241 . Let me file a JIRA.
          Hide
          Tsz Wo Nicholas Sze added a comment -
          Show
          Tsz Wo Nicholas Sze added a comment - Filed MAPREDUCE-2805 .
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #761 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/761/)
          MAPREDUCE-2797. Update mapreduce tests and RAID for HDFS-2239.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156215
          Files :

          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #761 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/761/ ) MAPREDUCE-2797 . Update mapreduce tests and RAID for HDFS-2239 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156215 Files : /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #752 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/752/)
          MAPREDUCE-2797. Update mapreduce tests and RAID for HDFS-2239.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156215
          Files :

          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #752 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/752/ ) MAPREDUCE-2797 . Update mapreduce tests and RAID for HDFS-2239 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156215 Files : /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCache.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestBinaryTokenFile.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRaid.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/security/TestTokenCacheOldApi.java
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          6h 15m 1 Aaron T. Myers 10/Aug/11 16:51
          Patch Available Patch Available Resolved Resolved
          5m 15s 1 Tsz Wo Nicholas Sze 10/Aug/11 16:56
          Resolved Resolved Closed Closed
          96d 8h 53m 1 Arun C Murthy 15/Nov/11 00:50

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development