Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.2, 0.20.205.0
    • Fix Version/s: 0.20.205.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
      MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.

        Activity

        Hide
        Sherry Chen added a comment -

        Back-port MAPREDUCE:2238 to 0.20-security.

        Show
        Sherry Chen added a comment - Back-port MAPREDUCE:2238 to 0.20-security.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485489/MAPREDUCE-2650.patch
        against trunk revision 1143252.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/438//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485489/MAPREDUCE-2650.patch against trunk revision 1143252. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/438//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        the changes in TaskLog seem to change semantics – it used to just WARN if permissions couldn't be set, but now it throws an exception?

        Show
        Todd Lipcon added a comment - the changes in TaskLog seem to change semantics – it used to just WARN if permissions couldn't be set, but now it throws an exception?
        Hide
        Sherry Chen added a comment -

        Todd,
        I think you are referring IOException in Localizer.java.
        It throws an exception when makedirs failed, not permission couldn't be set.

        Show
        Sherry Chen added a comment - Todd, I think you are referring IOException in Localizer.java. It throws an exception when makedirs failed, not permission couldn't be set.
        Hide
        Sherry Chen added a comment -

        Todd,
        I did not make it clear in previous comment.
        Throws an exception (when makedirs failed) semantics are used in trunk and CDH3.
        It's good to put it in 0.20-security.

        Show
        Sherry Chen added a comment - Todd, I did not make it clear in previous comment. Throws an exception (when makedirs failed) semantics are used in trunk and CDH3. It's good to put it in 0.20-security.
        Hide
        Mahadev konar added a comment -

        Sherry,
        I think Todd's comment was on localFS.setPermission() calls. Those calls would throw an exception in this patch and would just return false with a log warning in the original code. Is that correct?

        Infact all the calls to setpermission have to been changed.

        The mkdirs change is ok, but the other changes am not sure should be part of this patch?

        Show
        Mahadev konar added a comment - Sherry, I think Todd's comment was on localFS.setPermission() calls. Those calls would throw an exception in this patch and would just return false with a log warning in the original code. Is that correct? Infact all the calls to setpermission have to been changed. The mkdirs change is ok, but the other changes am not sure should be part of this patch?
        Hide
        Mahadev konar added a comment -

        Actually just read through the comments in MAPREDUCE-2238. The patch looks good.

        can you please post the results of ant test?

        Show
        Mahadev konar added a comment - Actually just read through the comments in MAPREDUCE-2238 . The patch looks good. can you please post the results of ant test?
        Hide
        Sherry Chen added a comment -

        ant test passed.

        Show
        Sherry Chen added a comment - ant test passed.
        Hide
        Mahadev konar added a comment -

        I just pushed this. Thanks Sherry!

        Show
        Mahadev konar added a comment - I just pushed this. Thanks Sherry!
        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0

          People

          • Assignee:
            Sherry Chen
            Reporter:
            Sherry Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development