[MAPREDUCE-2630] MR-279: refreshQueues leads to NPEs when used w/FifoScheduler

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.23.0
• Component/s: mrv2

Environment

All

• Hadoop Flags: Reviewed
• Assignee: Josh Wills
• Reporter: Josh Wills
• Created: 29/Jun/11 06:38
• Updated: 15/Nov/11 00:50
• Resolved: 13/Jul/11 03:02

Description

The RM's admin service exposes a method refreshQueues that is used to update the queue configuration when used with the CapacityScheduler, but if it is used with the FifoScheduler, it will set the containerTokenSecretManager/clusterTracker fields on the FifoScheduler to null, which eventually leads to NPE. Since the FifoScheduler only has one queue that cannot be refreshed, the correct behavior is for the refreshQueues call to be a no-op.

I will attach a patch that fixes this by splitting the ResourceScheduler's reinitialize method into separate initialize/updateQueues methods.

Issue Links

• is related to: MAPREDUCE-279 Map-Reduce 2.0