Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2610

Inconsistent API JobClient.getQueueAclsForCurrentUser

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 0.20.205.0
    • Component/s: client
    • Labels:
      None

      Description

      Client needs access to the current user's queue name.
      Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
      The QueueAclsInfo class has default access. A public method should not return a package-private class.

      The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.

        Activity

        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0
        Arun C Murthy made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.20.205.0 [ 12316391 ]
        Resolution Fixed [ 1 ]
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks Joep!

        Show
        Arun C Murthy added a comment - I just committed this. Thanks Joep!
        Hide
        Mahadev konar added a comment -

        +1 for the patch. Is this marked for 205?

        Show
        Mahadev konar added a comment - +1 for the patch. Is this marked for 205?
        Hide
        Joep Rottinghuis added a comment -

        This is also not a problem on 0.22, which is the same as trunk in this regard.
        Both getQueueName and getOperations are public in the new class.

        Show
        Joep Rottinghuis added a comment - This is also not a problem on 0.22, which is the same as trunk in this regard. Both getQueueName and getOperations are public in the new class.
        Hide
        Joep Rottinghuis added a comment -

        No this is not a problem on trunk.
        org/apache/hadoop/mapred/QueueAclsInfo.java
        is deprecated and the new
        org/apache/hadoop/mapreduce/QueueAclsInfo.java
        does not suffer from the same problems.

        As you know both can be found in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/

        Show
        Joep Rottinghuis added a comment - No this is not a problem on trunk. org/apache/hadoop/mapred/QueueAclsInfo.java is deprecated and the new org/apache/hadoop/mapreduce/QueueAclsInfo.java does not suffer from the same problems. As you know both can be found in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/
        Hide
        Joep Rottinghuis added a comment -

        Don't remember off the top of my head. Will check and get back to you.

        Show
        Joep Rottinghuis added a comment - Don't remember off the top of my head. Will check and get back to you.
        Hide
        Arun C Murthy added a comment -

        Joep, so this isn't a problem for trunk?

        Show
        Arun C Murthy added a comment - Joep, so this isn't a problem for trunk?
        Joep Rottinghuis made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Joep Rottinghuis made changes -
        Assignee Joep Rottinghuis [ jrottinghuis ]
        Priyo Mustafi made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-2610.patch [ 12483328 ]
        Hide
        Priyo Mustafi added a comment -

        Patch file

        Show
        Priyo Mustafi added a comment - Patch file
        Hide
        Joep Rottinghuis added a comment -

        Note that this class is deprecated on trunk (see MAPREDUCE-777), but its replacement in the o.a.h.mapreduce package does have public access to get to the queue and operations.

        Show
        Joep Rottinghuis added a comment - Note that this class is deprecated on trunk (see MAPREDUCE-777 ), but its replacement in the o.a.h.mapreduce package does have public access to get to the queue and operations.
        Joep Rottinghuis created issue -

          People

          • Assignee:
            Joep Rottinghuis
            Reporter:
            Joep Rottinghuis
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development