Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2576

Typo in comment in SimulatorLaunchTaskAction.java

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      trunk

    • Hadoop Flags:
      Reviewed

      Description

      This JIRA is to track a fix to a super-trivial issue of a typo of "or" misspelled as "xor " in Line 24 of SimulatorLaunchTaskAction.java

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #729 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/729/)
        MAPREDUCE-2576. Typo in comment in SimulatorLaunchTaskAction.java. Contributed by Tim Sell.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1136261
        Files :

        • /hadoop/common/trunk/mapreduce/CHANGES.txt
        • /hadoop/common/trunk/mapreduce/src/contrib/mumak/src/java/org/apache/hadoop/mapred/SimulatorLaunchTaskAction.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #729 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/729/ ) MAPREDUCE-2576 . Typo in comment in SimulatorLaunchTaskAction.java. Contributed by Tim Sell. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1136261 Files : /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/contrib/mumak/src/java/org/apache/hadoop/mapred/SimulatorLaunchTaskAction.java
        Hide
        Jakob Homan added a comment -

        I've committed this. Resolving as fixed. Thanks for the contribution, Tim!

        Show
        Jakob Homan added a comment - I've committed this. Resolving as fixed. Thanks for the contribution, Tim!
        Hide
        Jakob Homan added a comment -

        That's an impressive number of failed tests for a comment-fixing patch. Jenkins is wrong. This is ready to be committed.

        Show
        Jakob Homan added a comment - That's an impressive number of failed tests for a comment-fixing patch. Jenkins is wrong. This is ready to be committed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481929/MAPREDUCE-2576.patch
        against trunk revision 1134850.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestMRCLI
        org.apache.hadoop.conf.TestNoDefaultsJobConf
        org.apache.hadoop.examples.terasort.TestTeraSort
        org.apache.hadoop.fs.TestDFSIO
        org.apache.hadoop.fs.TestFileSystem
        org.apache.hadoop.ipc.TestSocketFactory
        org.apache.hadoop.mapred.join.TestDatamerge
        org.apache.hadoop.mapred.lib.TestDelegatingInputFormat
        org.apache.hadoop.mapred.pipes.TestPipes
        org.apache.hadoop.mapred.TestBadRecords
        org.apache.hadoop.mapred.TestClusterMapReduceTestCase
        org.apache.hadoop.mapred.TestCommandLineJobSubmission
        org.apache.hadoop.mapred.TestCompressedEmptyMapOutputs
        org.apache.hadoop.mapred.TestControlledMapReduceJob
        org.apache.hadoop.mapred.TestFileInputFormat
        org.apache.hadoop.mapred.TestJobClient
        org.apache.hadoop.mapred.TestJobDirCleanup
        org.apache.hadoop.mapred.TestJobHistory
        org.apache.hadoop.mapred.TestJobName
        org.apache.hadoop.mapred.TestJobQueueInformation
        org.apache.hadoop.mapred.TestJobStatusPersistency
        org.apache.hadoop.mapred.TestJobSysDirWithDFS
        org.apache.hadoop.mapred.TestJobTrackerXmlJsp
        org.apache.hadoop.mapred.TestLazyOutput
        org.apache.hadoop.mapred.TestMapredHeartbeat
        org.apache.hadoop.mapred.TestMapredSystemDir
        org.apache.hadoop.mapred.TestMiniMRChildTask
        org.apache.hadoop.mapred.TestMiniMRClasspath
        org.apache.hadoop.mapred.TestMiniMRDFSCaching
        org.apache.hadoop.mapred.TestMiniMRDFSSort
        org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
        org.apache.hadoop.mapred.TestMiniMRWithDFS
        org.apache.hadoop.mapred.TestMultipleLevelCaching
        org.apache.hadoop.mapred.TestNodeRefresh
        org.apache.hadoop.mapred.TestRecoveryManager
        org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
        org.apache.hadoop.mapred.TestReduceFetch
        org.apache.hadoop.mapred.TestSetupAndCleanupFailure
        org.apache.hadoop.mapred.TestSeveral
        org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath
        org.apache.hadoop.mapred.TestSubmitJob
        org.apache.hadoop.mapred.TestTaskFail
        org.apache.hadoop.mapred.TestWebUIAuthorization
        org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat
        org.apache.hadoop.mapreduce.lib.input.TestDelegatingInputFormat
        org.apache.hadoop.mapreduce.lib.join.TestJoinDatamerge
        org.apache.hadoop.mapreduce.lib.join.TestJoinProperties
        org.apache.hadoop.mapreduce.security.TestBinaryTokenFile
        org.apache.hadoop.mapreduce.security.TestTokenCacheOldApi
        org.apache.hadoop.mapreduce.security.TestTokenCache
        org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
        org.apache.hadoop.mapreduce.TestMRJobClient
        org.apache.hadoop.security.authorize.TestServiceLevelAuthorization
        org.apache.hadoop.security.TestMapredGroupMappingServiceRefresh
        org.apache.hadoop.tools.TestCopyFiles
        org.apache.hadoop.tools.TestDistCh
        org.apache.hadoop.tools.TestHadoopArchives
        org.apache.hadoop.tools.TestHarFileSystem

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/379//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/379//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/379//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481929/MAPREDUCE-2576.patch against trunk revision 1134850. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.conf.TestNoDefaultsJobConf org.apache.hadoop.examples.terasort.TestTeraSort org.apache.hadoop.fs.TestDFSIO org.apache.hadoop.fs.TestFileSystem org.apache.hadoop.ipc.TestSocketFactory org.apache.hadoop.mapred.join.TestDatamerge org.apache.hadoop.mapred.lib.TestDelegatingInputFormat org.apache.hadoop.mapred.pipes.TestPipes org.apache.hadoop.mapred.TestBadRecords org.apache.hadoop.mapred.TestClusterMapReduceTestCase org.apache.hadoop.mapred.TestCommandLineJobSubmission org.apache.hadoop.mapred.TestCompressedEmptyMapOutputs org.apache.hadoop.mapred.TestControlledMapReduceJob org.apache.hadoop.mapred.TestFileInputFormat org.apache.hadoop.mapred.TestJobClient org.apache.hadoop.mapred.TestJobDirCleanup org.apache.hadoop.mapred.TestJobHistory org.apache.hadoop.mapred.TestJobName org.apache.hadoop.mapred.TestJobQueueInformation org.apache.hadoop.mapred.TestJobStatusPersistency org.apache.hadoop.mapred.TestJobSysDirWithDFS org.apache.hadoop.mapred.TestJobTrackerXmlJsp org.apache.hadoop.mapred.TestLazyOutput org.apache.hadoop.mapred.TestMapredHeartbeat org.apache.hadoop.mapred.TestMapredSystemDir org.apache.hadoop.mapred.TestMiniMRChildTask org.apache.hadoop.mapred.TestMiniMRClasspath org.apache.hadoop.mapred.TestMiniMRDFSCaching org.apache.hadoop.mapred.TestMiniMRDFSSort org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers org.apache.hadoop.mapred.TestMiniMRWithDFS org.apache.hadoop.mapred.TestMultipleLevelCaching org.apache.hadoop.mapred.TestNodeRefresh org.apache.hadoop.mapred.TestRecoveryManager org.apache.hadoop.mapred.TestReduceFetchFromPartialMem org.apache.hadoop.mapred.TestReduceFetch org.apache.hadoop.mapred.TestSetupAndCleanupFailure org.apache.hadoop.mapred.TestSeveral org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath org.apache.hadoop.mapred.TestSubmitJob org.apache.hadoop.mapred.TestTaskFail org.apache.hadoop.mapred.TestWebUIAuthorization org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat org.apache.hadoop.mapreduce.lib.input.TestDelegatingInputFormat org.apache.hadoop.mapreduce.lib.join.TestJoinDatamerge org.apache.hadoop.mapreduce.lib.join.TestJoinProperties org.apache.hadoop.mapreduce.security.TestBinaryTokenFile org.apache.hadoop.mapreduce.security.TestTokenCacheOldApi org.apache.hadoop.mapreduce.security.TestTokenCache org.apache.hadoop.mapreduce.TestMapReduceLazyOutput org.apache.hadoop.mapreduce.TestMRJobClient org.apache.hadoop.security.authorize.TestServiceLevelAuthorization org.apache.hadoop.security.TestMapredGroupMappingServiceRefresh org.apache.hadoop.tools.TestCopyFiles org.apache.hadoop.tools.TestDistCh org.apache.hadoop.tools.TestHadoopArchives org.apache.hadoop.tools.TestHarFileSystem -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/379//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/379//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/379//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481929/MAPREDUCE-2576.patch
        against trunk revision 1133226.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestMRCLI
        org.apache.hadoop.fs.TestFileSystem

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/368//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/368//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/368//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481929/MAPREDUCE-2576.patch against trunk revision 1133226. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/368//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/368//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/368//console This message is automatically generated.
        Hide
        Jonathan Eagles added a comment -

        Welcome to the community Sherry. Changes look great

        +1

        Show
        Jonathan Eagles added a comment - Welcome to the community Sherry. Changes look great +1
        Hide
        Jakob Homan added a comment -

        +1

        Show
        Jakob Homan added a comment - +1
        Hide
        Jonathan Eagles added a comment -

        While your at it, go ahead and fix the spelling of successfull -> successful

        Show
        Jonathan Eagles added a comment - While your at it, go ahead and fix the spelling of successfull -> successful

          People

          • Assignee:
            Tim Sell
            Reporter:
            Sherry Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development