Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2569

MR-279: Restarting resource manager with root capacity not equal to 100 percent should result in error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      mr-279, mrv2

      Description

      root.capacity is set to 90% without failure

      1. MAPREDUCE-2569-MR-279-v1.patch
        2 kB
        Jonathan Eagles
      2. MAPREDUCE-2569-MR-279-v2.patch
        3 kB
        Jonathan Eagles

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481825/MAPREDUCE-2569-MR-279-v1.patch
        against trunk revision 1133226.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/362//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481825/MAPREDUCE-2569-MR-279-v1.patch against trunk revision 1133226. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/362//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        Looks good to me.

        Show
        Robert Joseph Evans added a comment - Looks good to me.
        Hide
        Jonathan Eagles added a comment -

        Currenty, capacity at every level except the root level in the hierarchical queues is required to sum to 100% and throw IllegalArgumentException otherwise. This patch further extends this to required capacity at the root level to also be 100%, throwing IllegalArgumentException otherwise.

        Show
        Jonathan Eagles added a comment - Currenty, capacity at every level except the root level in the hierarchical queues is required to sum to 100% and throw IllegalArgumentException otherwise. This patch further extends this to required capacity at the root level to also be 100%, throwing IllegalArgumentException otherwise.
        Hide
        Arun C Murthy added a comment -

        Jonathan, I'd just move the check to ParentQueue.ParentQueue or ParentQueue.setupQueueConfigs rather than do it CapacitySchedulerConfiguration.

        Show
        Arun C Murthy added a comment - Jonathan, I'd just move the check to ParentQueue.ParentQueue or ParentQueue.setupQueueConfigs rather than do it CapacitySchedulerConfiguration.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482105/MAPREDUCE-2569-MR-279-v2.patch
        against trunk revision 1134180.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/374//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482105/MAPREDUCE-2569-MR-279-v2.patch against trunk revision 1134180. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/374//console This message is automatically generated.
        Hide
        Jonathan Eagles added a comment -

        v2 of the patch incorporates Arun's comments

        Show
        Jonathan Eagles added a comment - v2 of the patch incorporates Arun's comments
        Hide
        Arun C Murthy added a comment -

        +1, looks good.

        Show
        Arun C Murthy added a comment - +1, looks good.
        Hide
        Jonathan Eagles added a comment -

        Thanks, Arun.

        Show
        Jonathan Eagles added a comment - Thanks, Arun.
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks, Jon!

        Show
        Chris Douglas added a comment - I committed this. Thanks, Jon!

          People

          • Assignee:
            Jonathan Eagles
            Reporter:
            Jonathan Eagles
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development