Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.22.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Option topology.node.switch.mapping.impl has been renamed to net.topology.node.switch.mapping.impl; JT still uses old name. Likewise, JT uses old names for several other since-renamed options.

      1. MAPREDUCE-2515.txt
        3 kB
        Ari Rabkin
      2. MAPREDUCE-2515.txt
        3 kB
        Ari Rabkin
      3. MAPREDUCE-2515.txt
        0.8 kB
        Ari Rabkin

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        47m 36s 1 Ari Rabkin 18/May/11 23:00
        Open Open Patch Available Patch Available
        34m 25s 2 Ari Rabkin 18/May/11 23:07
        Patch Available Patch Available Resolved Resolved
        2h 48m 1 Todd Lipcon 19/May/11 01:55
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/684/)
        MAPREDUCE-2515. MapReduce code references some deprecated options. Contributed by Ari Rabkin.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124509
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/684/ ) MAPREDUCE-2515 . MapReduce code references some deprecated options. Contributed by Ari Rabkin. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124509 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #55 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/55/)
        MAPREDUCE-2515. MapReduce code references some deprecated options. Contributed by Ari Rabkin.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124508
        Files :

        • /hadoop/mapreduce/branches/branch-0.22/src/java/org/apache/hadoop/mapred/JobTracker.java
        • /hadoop/mapreduce/branches/branch-0.22/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #55 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/55/ ) MAPREDUCE-2515 . MapReduce code references some deprecated options. Contributed by Ari Rabkin. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124508 Files : /hadoop/mapreduce/branches/branch-0.22/src/java/org/apache/hadoop/mapred/JobTracker.java /hadoop/mapreduce/branches/branch-0.22/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #683 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/683/)
        MAPREDUCE-2515. MapReduce code references some deprecated options. Contributed by Ari Rabkin.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124509
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #683 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/683/ ) MAPREDUCE-2515 . MapReduce code references some deprecated options. Contributed by Ari Rabkin. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124509 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479687/MAPREDUCE-2515.txt
        against trunk revision 1124383.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/271//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/271//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/271//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479687/MAPREDUCE-2515.txt against trunk revision 1124383. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/271//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/271//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/271//console This message is automatically generated.
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314184 ]
        Fix Version/s 0.23.0 [ 12315570 ]
        Resolution Fixed [ 1 ]
        Hide
        Todd Lipcon added a comment -

        Committed to trunk and branch-22. Thanks, Ari!

        Show
        Todd Lipcon added a comment - Committed to trunk and branch-22. Thanks, Ari!
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479662/MAPREDUCE-2515.txt
        against trunk revision 1124383.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/269//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/269//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/269//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479662/MAPREDUCE-2515.txt against trunk revision 1124383. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/269//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/269//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/269//console This message is automatically generated.
        Ari Rabkin made changes -
        Attachment MAPREDUCE-2515.txt [ 12479687 ]
        Hide
        Ari Rabkin added a comment -

        Now with lines that are only 80 characters.

        Show
        Ari Rabkin added a comment - Now with lines that are only 80 characters.
        Ari Rabkin made changes -
        Description Option topology.node.switch.mapping.impl has been renamed to net.topology.node.switch.mapping.impl; JT still uses old name.
        Option topology.node.switch.mapping.impl has been renamed to net.topology.node.switch.mapping.impl; JT still uses old name. Likewise, JT uses old names for several other since-renamed options.
        Ari Rabkin made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Ari Rabkin made changes -
        Attachment MAPREDUCE-2515.txt [ 12479686 ]
        Ari Rabkin made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Ari Rabkin made changes -
        Summary MapReduce references obsolete option topology.node.switch.mapping.impl MapReduce references obsolete options
        Hide
        Ari Rabkin added a comment -

        Actually, there are a bunch of obsolete options referenced in there. Broadening scope of this issue...

        Show
        Ari Rabkin added a comment - Actually, there are a bunch of obsolete options referenced in there. Broadening scope of this issue...
        Ari Rabkin made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ari Rabkin added a comment -

        Note: Patch is one line, changing an option name. No unit tests should be affected, and any tests for this functionality will be far more brittle than the patch itself.

        Show
        Ari Rabkin added a comment - Note: Patch is one line, changing an option name. No unit tests should be affected, and any tests for this functionality will be far more brittle than the patch itself.
        Ari Rabkin made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-2515.txt [ 12479662 ]
        Ari Rabkin created issue -

          People

          • Assignee:
            Ari Rabkin
            Reporter:
            Ari Rabkin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development