Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.20.2
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Error message(s) are missing spaces. Here's an example output:
      11/05/15 09:44:10 WARN mapred.JobClient: Error reading task outputhttp://
      Generated from this line of source.

      ./src/mapred/org/apache/hadoop/mapred/JobClient.java: LOG.warn("Error reading task output" + ioe.getMessage());

      The 1st arg to LOG.warn should end with a ' '.

      There may be other instances of this problem in the source base.

        Activity

        Hide
        Todd Lipcon added a comment -

        Hi Robert. Would you be interested in contributing a patch for this issue against the trunk MapReduce svn repo? Thanks.

        Show
        Todd Lipcon added a comment - Hi Robert. Would you be interested in contributing a patch for this issue against the trunk MapReduce svn repo? Thanks.
        Hide
        Eli Collins added a comment -

        Trivial patch attached.

        Show
        Eli Collins added a comment - Trivial patch attached.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Eli Collins added a comment -

        Thanks Todd. I've committed this to trunk.

        Show
        Eli Collins added a comment - Thanks Todd. I've committed this to trunk.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #679 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/679/)
        MAPREDUCE-2497. Missing spaces in error messages. Contributed by Eli Collins

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104599
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/Job.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #679 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/679/ ) MAPREDUCE-2497 . Missing spaces in error messages. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104599 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/Job.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479424/mapreduce-2497-1.patch
        against trunk revision 1103993.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/260//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/260//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/260//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479424/mapreduce-2497-1.patch against trunk revision 1103993. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/260//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/260//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/260//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #683 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/683/)
        MAPREDUCE-2497. Missing spaces in error messages. Contributed by Eli Collins

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104599
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/Job.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #683 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/683/ ) MAPREDUCE-2497 . Missing spaces in error messages. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104599 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/Job.java

          People

          • Assignee:
            Eli Collins
            Reporter:
            Robert Henry
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development