Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2489

Jobsplits with random hostnames can make the queue unusable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0, 0.23.0
    • Fix Version/s: 0.20.205.0, 0.23.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We saw an issue where a custom InputSplit was returning invalid hostnames for the splits that were then causing the JobTracker to attempt to excessively resolve host names. This caused a major slowdown for the JobTracker. We should prevent invalid InputSplit hostnames from affecting everyone else.

      I propose we implement some verification for the hostnames to try to ensure that we only do DNS lookups on valid hostnames (and fail otherwise). We could also fail the job after a certain number of failures in the resolve.

      1. MAPREDUCE-2489-mapred.patch
        6 kB
        Jeffrey Naisbitt
      2. MAPREDUCE-2489-mapred-v2.patch
        6 kB
        Jeffrey Naisbitt
      3. MAPREDUCE-2489-0.20s.patch
        17 kB
        Jeffrey Naisbitt
      4. MAPREDUCE-2489-0.20s-v2.patch
        16 kB
        Jeffrey Naisbitt
      5. MAPREDUCE-2489-mapred-v3.patch
        6 kB
        Jeffrey Naisbitt
      6. MAPREDUCE-2489-0.20s-v3.patch
        6 kB
        Jeffrey Naisbitt
      7. MAPREDUCE-2489-mapred-v4.patch
        6 kB
        Jeffrey Naisbitt
      8. MAPREDUCE-2489-0.20s-v4.patch
        8 kB
        Jeffrey Naisbitt
      9. MAPREDUCE-2489-mapred-v5.patch
        4 kB
        Jeffrey Naisbitt
      10. MAPREDUCE-2489-0.20s-v5.patch
        9 kB
        Jeffrey Naisbitt
      11. MAPREDUCE-2489-mapred-v6.patch
        6 kB
        Jeffrey Naisbitt
      12. MAPREDUCE-2489-0.20s-v6.patch
        7 kB
        Jeffrey Naisbitt
      13. MAPREDUCE-2489-mapred-v7.patch
        2 kB
        Jeffrey Naisbitt

        Issue Links

          Activity

          Hide
          Allen Wittenauer added a comment -

          I'm assuming no nscd or dns cache was running on the JT?

          Show
          Allen Wittenauer added a comment - I'm assuming no nscd or dns cache was running on the JT?
          Hide
          Jeffrey Naisbitt added a comment -

          Honestly, I'm not sure what caching was enabled at the time. How would caching have helped in this case though - where we have basically tons of lookups on garbage hostnames? (none of these strings are repeated)

          Show
          Jeffrey Naisbitt added a comment - Honestly, I'm not sure what caching was enabled at the time. How would caching have helped in this case though - where we have basically tons of lookups on garbage hostnames? (none of these strings are repeated)
          Hide
          Allen Wittenauer added a comment -

          Ah, ok, the non-repeating hostnames wasn't clear in the description.

          Show
          Allen Wittenauer added a comment - Ah, ok, the non-repeating hostnames wasn't clear in the description.
          Hide
          Jeffrey Naisbitt added a comment -

          @Allen, apologies for not being clear in the description.

          Also, I expect this patch will fail in the Hudson build until HADOOP-7314 has been committed.

          Show
          Jeffrey Naisbitt added a comment - @Allen, apologies for not being clear in the description. Also, I expect this patch will fail in the Hudson build until HADOOP-7314 has been committed.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/776/
          -----------------------------------------------------------

          Review request for hadoop-mapreduce.

          Summary
          -------

          We saw an issue where a custom InputSplit was returning invalid hostnames (non-repeating) for the splits that were then causing the JobTracker to attempt to excessively resolve host names. This caused a major slowdown for the JobTracker. We should prevent invalid InputSplit hostnames from affecting everyone else.

          I propose we implement some verification for the hostnames to try to ensure that we only do DNS lookups on valid hostnames (and fail otherwise). We could also fail the job after a certain number of failures in the resolve.

          NOTE: This requires the changes in HADOOP-7314

          This addresses bug MAPREDUCE-2489.
          https://issues.apache.org/jira/browse/MAPREDUCE-2489

          Diffs


          trunk/ivy.xml 1125074
          trunk/ivy/libraries.properties 1125074
          trunk/src/contrib/mumak/src/java/org/apache/hadoop/mapred/SimulatorJobTracker.java 1125074
          trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java 1125074
          trunk/src/java/org/apache/hadoop/mapred/JobTracker.java 1125074

          Diff: https://reviews.apache.org/r/776/diff

          Testing
          -------

          Thanks,

          Jeffrey

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/776/ ----------------------------------------------------------- Review request for hadoop-mapreduce. Summary ------- We saw an issue where a custom InputSplit was returning invalid hostnames (non-repeating) for the splits that were then causing the JobTracker to attempt to excessively resolve host names. This caused a major slowdown for the JobTracker. We should prevent invalid InputSplit hostnames from affecting everyone else. I propose we implement some verification for the hostnames to try to ensure that we only do DNS lookups on valid hostnames (and fail otherwise). We could also fail the job after a certain number of failures in the resolve. NOTE: This requires the changes in HADOOP-7314 This addresses bug MAPREDUCE-2489 . https://issues.apache.org/jira/browse/MAPREDUCE-2489 Diffs trunk/ivy.xml 1125074 trunk/ivy/libraries.properties 1125074 trunk/src/contrib/mumak/src/java/org/apache/hadoop/mapred/SimulatorJobTracker.java 1125074 trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java 1125074 trunk/src/java/org/apache/hadoop/mapred/JobTracker.java 1125074 Diff: https://reviews.apache.org/r/776/diff Testing ------- Thanks, Jeffrey
          Hide
          Jeffrey Naisbitt added a comment -

          Address the comments Robert Evans made in HADOOP-7314, making urlValidator a static member variable.

          Show
          Jeffrey Naisbitt added a comment - Address the comments Robert Evans made in HADOOP-7314 , making urlValidator a static member variable.
          Hide
          Jeffrey Naisbitt added a comment -

          Patch for the 20-security branch

          Show
          Jeffrey Naisbitt added a comment - Patch for the 20-security branch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12482679/MAPREDUCE-2489-0.20s.patch
          against trunk revision 1136000.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/397//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482679/MAPREDUCE-2489-0.20s.patch against trunk revision 1136000. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/397//console This message is automatically generated.
          Hide
          Jeffrey Naisbitt added a comment -

          Test-patch results for 20-security patch:
          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 6 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          Show
          Jeffrey Naisbitt added a comment - Test-patch results for 20-security patch: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          Hide
          Jeffrey Naisbitt added a comment -

          Going to try using java.net.URI instead of UrlValidator to get rid of all the extra dependency stuff.

          Show
          Jeffrey Naisbitt added a comment - Going to try using java.net.URI instead of UrlValidator to get rid of all the extra dependency stuff.
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patch for the 0.20-security branch

          Show
          Jeffrey Naisbitt added a comment - Updated patch for the 0.20-security branch
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patch for trunk

          Show
          Jeffrey Naisbitt added a comment - Updated patch for trunk
          Hide
          Jeffrey Naisbitt added a comment -

          test-patch results for the 0.20s patch:
          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 9 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          Show
          Jeffrey Naisbitt added a comment - test-patch results for the 0.20s patch: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483623/MAPREDUCE-2489-mapred-v3.patch
          against trunk revision 1138301.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/413//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/413//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483623/MAPREDUCE-2489-mapred-v3.patch against trunk revision 1138301. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/413//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/413//console This message is automatically generated.
          Hide
          Jeffrey Naisbitt added a comment -

          Again, this patch will fail until HADOOP-7314 has been committed.

          Show
          Jeffrey Naisbitt added a comment - Again, this patch will fail until HADOOP-7314 has been committed.
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patch for 0.20.205 - removing the portion of the code corresponding to HADOOP-7314 from this patch and placing it in its own patch on that jira.

          Show
          Jeffrey Naisbitt added a comment - Updated patch for 0.20.205 - removing the portion of the code corresponding to HADOOP-7314 from this patch and placing it in its own patch on that jira.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486481/MAPREDUCE-2489-mapred-v4.patch
          against trunk revision 1146517.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/467//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/467//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486481/MAPREDUCE-2489-mapred-v4.patch against trunk revision 1146517. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/467//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/467//console This message is automatically generated.
          Hide
          Jeffrey Naisbitt added a comment -

          Resubmitting patch to run through hudson

          Show
          Jeffrey Naisbitt added a comment - Resubmitting patch to run through hudson
          Hide
          Jeffrey Naisbitt added a comment -

          Not sure why Hudson didn't run, but here are the latest test-patch results for both 0.20s and trunk:
          0.20s:
          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          trunk:

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system test framework. The patch passed system test framework compile.
          [exec]

          The extra Findbugs warning seems to be unrelated to this patch.

          Show
          Jeffrey Naisbitt added a comment - Not sure why Hudson didn't run, but here are the latest test-patch results for both 0.20s and trunk: 0.20s: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. trunk: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] The extra Findbugs warning seems to be unrelated to this patch.
          Hide
          Mahadev konar added a comment -

          Jeffrey,
          Sorry, I am a little unclear on what the patch is doing. Can you please specify what you are trying to achieve with the patch? The patch seems to create a URI with hostname and checking if its a valid URI or not? How is that verifying if a hostname is valid or not?

          Show
          Mahadev konar added a comment - Jeffrey, Sorry, I am a little unclear on what the patch is doing. Can you please specify what you are trying to achieve with the patch? The patch seems to create a URI with hostname and checking if its a valid URI or not? How is that verifying if a hostname is valid or not?
          Hide
          Jeffrey Naisbitt added a comment -

          Mahadev,
          There are two parts to this patch. The most important is the use of the new "resolveValidHosts" function and throwing the UnknownHostException up the chain. That part ensures that the hostnames are actually valid and is needed to resolve the problem this Jira was filed for.

          The second part (that you describe above) is meant to only be an early sanity check. All it is trying to do is ensure that the hostnames "appear" to be valid. With this, I'm just trying to check the hostname string itself to see that it contains valid characters and such so we can fail early on if the hostname string contains garbage (like in the original case this Jira was filed for). The URI object seemed the easiest and most standard way I could find to do this. The URI object creation will fail, or the uri.getHost() method will return null if the string passed in doesn't match their regular expressions for what a URI should look like (which includes checking the hostname portion). The URI object requires a schema (http://, ftp://, etc.), so I add one on if it doesn't already have one in the string. Again, this is only really meant to catch the garbage string cases, and it's not meant to be a perfect check that will catch all hostname problems (those are caught by the first part of the patch mentioned above).

          Does that make sense? If you have other questions or suggestions, please let me know
          Thanks for looking at it!

          Show
          Jeffrey Naisbitt added a comment - Mahadev, There are two parts to this patch. The most important is the use of the new "resolveValidHosts" function and throwing the UnknownHostException up the chain. That part ensures that the hostnames are actually valid and is needed to resolve the problem this Jira was filed for. The second part (that you describe above) is meant to only be an early sanity check. All it is trying to do is ensure that the hostnames "appear" to be valid. With this, I'm just trying to check the hostname string itself to see that it contains valid characters and such so we can fail early on if the hostname string contains garbage (like in the original case this Jira was filed for). The URI object seemed the easiest and most standard way I could find to do this. The URI object creation will fail, or the uri.getHost() method will return null if the string passed in doesn't match their regular expressions for what a URI should look like (which includes checking the hostname portion). The URI object requires a schema ( http:// , ftp:// , etc.), so I add one on if it doesn't already have one in the string. Again, this is only really meant to catch the garbage string cases, and it's not meant to be a perfect check that will catch all hostname problems (those are caught by the first part of the patch mentioned above). Does that make sense? If you have other questions or suggestions, please let me know Thanks for looking at it!
          Hide
          Mahadev konar added a comment -

          Jeffrey,
          One minor nit,

          The method:

          
            static void verifyHostnames(String[] names) throws UnknownHostException {
          

          does not seem appropriate for JobInProgress class. It needs to be moved out to some helper class. NetUtils seems more appropriate for this helper method. What do you think?

          Show
          Mahadev konar added a comment - Jeffrey, One minor nit, The method: static void verifyHostnames( String [] names) throws UnknownHostException { does not seem appropriate for JobInProgress class. It needs to be moved out to some helper class. NetUtils seems more appropriate for this helper method. What do you think?
          Hide
          Jeffrey Naisbitt added a comment -

          I agree. It would definitely fit better in NetUtils. I'll post new patches soon.

          Show
          Jeffrey Naisbitt added a comment - I agree. It would definitely fit better in NetUtils. I'll post new patches soon.
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patch for the 20-security branch - based on Mahadev's comments.

          Show
          Jeffrey Naisbitt added a comment - Updated patch for the 20-security branch - based on Mahadev's comments.
          Hide
          Jeffrey Naisbitt added a comment -

          20-security branch test-patch results:

          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          Show
          Jeffrey Naisbitt added a comment - 20-security branch test-patch results: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          Hide
          Jeffrey Naisbitt added a comment -

          Patch for trunk addressing Mahadev's comments. Note: this should not be committed until HADOOP-7499 has been committed to trunk.

          Show
          Jeffrey Naisbitt added a comment - Patch for trunk addressing Mahadev's comments. Note: this should not be committed until HADOOP-7499 has been committed to trunk.
          Hide
          Jeffrey Naisbitt added a comment -

          There appear to be some errors in some of the tests when running 'ant test'. I want to look into this first.

          Show
          Jeffrey Naisbitt added a comment - There appear to be some errors in some of the tests when running 'ant test'. I want to look into this first.
          Hide
          Jeffrey Naisbitt added a comment -

          Updated 20-security patch to fix issues with tests failing.

          test-patch results:
          [exec] +1 overall.

          [exec]

          [exec] +1 @author. The patch does not contain any @author tags.

          [exec]

          [exec] +1 tests included. The patch appears to include 6 new or modified tests.

          [exec]

          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.

          [exec]

          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          [exec]

          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          [exec]

          ==========================================
          mvn test results:
          All the tests pass that currently pass with the clean checkout.

          Show
          Jeffrey Naisbitt added a comment - Updated 20-security patch to fix issues with tests failing. test-patch results: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] ========================================== mvn test results: All the tests pass that currently pass with the clean checkout.
          Hide
          Jeffrey Naisbitt added a comment -

          I meant 'ant test' instead of 'mvn test'.
          I was running with ant-1.8.2, which apparently caused the test failures.
          All of the tests pass with ant-1.7.1

          Show
          Jeffrey Naisbitt added a comment - I meant 'ant test' instead of 'mvn test'. I was running with ant-1.8.2, which apparently caused the test failures. All of the tests pass with ant-1.7.1
          Hide
          Jeffrey Naisbitt added a comment -

          To clarify, all the tests pass for the 0.20s patch. I am still looking at the patch for trunk.

          Show
          Jeffrey Naisbitt added a comment - To clarify, all the tests pass for the 0.20s patch. I am still looking at the patch for trunk.
          Hide
          Mahadev konar added a comment -

          +1 for 0.20S patch. I have committed that to the branch. Thanks Jeffrey. I'll wait for the trunk common and mapred patches before closing this jira.

          Show
          Mahadev konar added a comment - +1 for 0.20S patch. I have committed that to the branch. Thanks Jeffrey. I'll wait for the trunk common and mapred patches before closing this jira.
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patch to fix an issue with some tests failing.

          Show
          Jeffrey Naisbitt added a comment - Updated patch to fix an issue with some tests failing.
          Hide
          Jeffrey Naisbitt added a comment -

          The only test failures on trunk are unrelated to this patch and fail with a clean checkout of trunk as well.

          trunk test-patch results (since this patch will fail until HADOOP-7499 has been committed):
          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] -1 system test framework. The patch failed system test framework compile.

          The extra findbugs warning is unrelated to this bug (Incorrect lazy initialization of static field org.apache.hadoop.mapred.TaskLog.localFS in org.apache.hadoop.mapred.TaskLog.writeToIndexFile(String, boolean))

          The system test framework is because HADOOP-7499 has not been committed yet.

          Show
          Jeffrey Naisbitt added a comment - The only test failures on trunk are unrelated to this patch and fail with a clean checkout of trunk as well. trunk test-patch results (since this patch will fail until HADOOP-7499 has been committed): [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 system test framework. The patch failed system test framework compile. The extra findbugs warning is unrelated to this bug (Incorrect lazy initialization of static field org.apache.hadoop.mapred.TaskLog.localFS in org.apache.hadoop.mapred.TaskLog.writeToIndexFile(String, boolean)) The system test framework is because HADOOP-7499 has not been committed yet.
          Hide
          Jeffrey Naisbitt added a comment -

          So, we discovered that the interface change is incompatible. So, we are removing the incompatible change and the corresponding portion of code relying on that change and implementing the sanity check only.

          Show
          Jeffrey Naisbitt added a comment - So, we discovered that the interface change is incompatible. So, we are removing the incompatible change and the corresponding portion of code relying on that change and implementing the sanity check only.
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patches removing the incompatible change and corresponding code references here.

          All tests pass on branch-0.20-security.

          branch-0.20-security test-patch results:
          test-patch results:
          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 6 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          [exec]

          ======================================================
          All tests pass in trunk except for those that are currently failing with a clean checkout of trunk as well (TestMRCLI, TestFileSystem, TestMapredSystemDir, TestLocalRunner, TestDBJob, TestDataDrivenDBInputFormat)

          test-patch results for trunk:
          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no new tests are needed for this patch.
          [exec] Also please list what manual steps were performed to verify this patch.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] -1 system test framework. The patch failed system test framework compile.
          [exec]

          The tests were added to the hadoop-common portion of this patch.
          The findbug warning is unrelated to this patch.
          The system test failure is during the -compile-fault-inject: phase because the hadoop-common changes have not been committed yet.

          Show
          Jeffrey Naisbitt added a comment - Updated patches removing the incompatible change and corresponding code references here. All tests pass on branch-0.20-security. branch-0.20-security test-patch results: test-patch results: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] ====================================================== All tests pass in trunk except for those that are currently failing with a clean checkout of trunk as well (TestMRCLI, TestFileSystem, TestMapredSystemDir, TestLocalRunner, TestDBJob, TestDataDrivenDBInputFormat) test-patch results for trunk: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 system test framework. The patch failed system test framework compile. [exec] The tests were added to the hadoop-common portion of this patch. The findbug warning is unrelated to this patch. The system test failure is during the -compile-fault-inject: phase because the hadoop-common changes have not been committed yet.
          Hide
          Mahadev konar added a comment -

          I just pushed this to 0.20 security and mapred trunk. Thanks Jeff!

          Show
          Mahadev konar added a comment - I just pushed this to 0.20 security and mapred trunk. Thanks Jeff!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #728 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/728/)
          MAPREDUCE-2489. Jobsplits with random hostnames can make the queue unusable (jeffrey naisbit via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156821
          Files :

          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #728 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/728/ ) MAPREDUCE-2489 . Jobsplits with random hostnames can make the queue unusable (jeffrey naisbit via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156821 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobInProgress.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #761 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/761/)
          MAPREDUCE-2489. Jobsplits with random hostnames can make the queue unusable (jeffrey naisbit via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156821
          Files :

          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #761 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/761/ ) MAPREDUCE-2489 . Jobsplits with random hostnames can make the queue unusable (jeffrey naisbit via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156821 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobInProgress.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #752 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/752/)
          MAPREDUCE-2489. Jobsplits with random hostnames can make the queue unusable (jeffrey naisbit via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156821
          Files :

          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #752 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/752/ ) MAPREDUCE-2489 . Jobsplits with random hostnames can make the queue unusable (jeffrey naisbit via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156821 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/JobInProgress.java
          Hide
          Matt Foley added a comment -

          Closed upon release of 0.20.205.0

          Show
          Matt Foley added a comment - Closed upon release of 0.20.205.0

            People

            • Assignee:
              Jeffrey Naisbitt
              Reporter:
              Jeffrey Naisbitt
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development