Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2473

MR portion of HADOOP-7214 - Hadoop /usr/bin/groups equivalent

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Introduces a new command, "mapred groups", which displays what groups are associated with a user as seen by the JobTracker.
    1. mapreduce-2473.3.patch
      8 kB
      Aaron T. Myers
    2. mapreduce-2473.2.patch
      8 kB
      Aaron T. Myers
    3. mapreduce-2473.1.patch
      8 kB
      Aaron T. Myers
    4. mapreduce-2473.0.patch
      11 kB
      Aaron T. Myers

      Issue Links

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #675 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/675/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #675 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/675/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #679 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/679/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #679 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/679/ )
        Hide
        Todd Lipcon added a comment -

        Committed to trunk. Thanks, Aaron!

        Show
        Todd Lipcon added a comment - Committed to trunk. Thanks, Aaron!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478777/mapreduce-2473.3.patch
        against trunk revision 1101741.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/227//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/227//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/227//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478777/mapreduce-2473.3.patch against trunk revision 1101741. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/227//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/227//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/227//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Rebased patch against trunk.

        Show
        Aaron T. Myers added a comment - Rebased patch against trunk.
        Hide
        Todd Lipcon added a comment -

        +1, but please re-attach patch so Hudson can re-run now that HADOOP-7214 is committed.

        Show
        Todd Lipcon added a comment - +1, but please re-attach patch so Hudson can re-run now that HADOOP-7214 is committed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478314/mapreduce-2473.2.patch
        against trunk revision 1099847.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/220//testReport/
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/220//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478314/mapreduce-2473.2.patch against trunk revision 1099847. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/220//testReport/ Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/220//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Thanks for the comments, Todd. Updated patch attached.

        Show
        Aaron T. Myers added a comment - Thanks for the comments, Todd. Updated patch attached.
        Hide
        Todd Lipcon added a comment -

        TestGetGroups.setUpNameNode and tearDownNameNode should be renamed to reflect that they setup/teardown the JT, not the NN.
        Also, In the Common patch, I don't see GetGroupsTestBase included.

        Show
        Todd Lipcon added a comment - TestGetGroups.setUpNameNode and tearDownNameNode should be renamed to reflect that they setup/teardown the JT, not the NN. Also, In the Common patch, I don't see GetGroupsTestBase included.
        Hide
        Aaron T. Myers added a comment -

        D'oh! I missed a license header. Fixed in this patch.

        Show
        Aaron T. Myers added a comment - D'oh! I missed a license header. Fixed in this patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478252/mapreduce-2473.1.patch
        against trunk revision 1099590.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/217//testReport/
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/217//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478252/mapreduce-2473.1.patch against trunk revision 1099590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/217//testReport/ Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/217//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Updated patch addressing Todd's comments.

        Show
        Aaron T. Myers added a comment - Updated patch addressing Todd's comments.
        Hide
        Todd Lipcon added a comment -

        I agree conceptually, but since our authorization here is service-level instead of more finer grained, we either need to split up the Protocols, or split up the authorization configuration.

        Show
        Todd Lipcon added a comment - I agree conceptually, but since our authorization here is service-level instead of more finer grained, we either need to split up the Protocols, or split up the authorization configuration.
        Hide
        Aaron T. Myers added a comment -

        It seems unfortunate that we're lumping in the "getGroups" API (an action intended for non-admin usage) with the refresh methods (admin actions). Unfortunately the ACLs for this whole Protocol are determined by "security.refresh.user.mappings.protocol.acl" which is a misnomer when it also affects the group command.

        Any thoughts on a way around this?

        Certainly. We could have a separate protocol interface for refreshing versus fetching user group mappings. It seemed logical to me to lump the two together, since they both cover user -> group mapping, but I don't feel very strongly about this.

        Show
        Aaron T. Myers added a comment - It seems unfortunate that we're lumping in the "getGroups" API (an action intended for non-admin usage) with the refresh methods (admin actions). Unfortunately the ACLs for this whole Protocol are determined by "security.refresh.user.mappings.protocol.acl" which is a misnomer when it also affects the group command. Any thoughts on a way around this? Certainly. We could have a separate protocol interface for refreshing versus fetching user group mappings. It seemed logical to me to lump the two together, since they both cover user -> group mapping, but I don't feel very strongly about this.
        Hide
        Todd Lipcon added a comment -

        It seems unfortunate that we're lumping in the "getGroups" API (an action intended for non-admin usage) with the refresh methods (admin actions). Unfortunately the ACLs for this whole Protocol are determined by "security.refresh.user.mappings.protocol.acl" which is a misnomer when it also affects the group command.

        Any thoughts on a way around this?

        Show
        Todd Lipcon added a comment - It seems unfortunate that we're lumping in the "getGroups" API (an action intended for non-admin usage) with the refresh methods (admin actions). Unfortunately the ACLs for this whole Protocol are determined by "security.refresh.user.mappings.protocol.acl" which is a misnomer when it also affects the group command. Any thoughts on a way around this?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478227/mapreduce-2473.0.patch
        against trunk revision 1099590.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/216//testReport/
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/216//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478227/mapreduce-2473.0.patch against trunk revision 1099590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/216//testReport/ Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/216//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Patch which uses the RefreshUserMappingsProtocol. This patch is dependent upon the latest patch posted to HADOOP-7214.

        Show
        Aaron T. Myers added a comment - Patch which uses the RefreshUserMappingsProtocol . This patch is dependent upon the latest patch posted to HADOOP-7214 .

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development