Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-245

Job and JobControl classes should return interfaces rather than implementations

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      See HADOOP-2202 and HADOOP-2268 for background on this. I am creating a new issue, since the previous two did not fix the problem, and it can be addressed when we make non backwards compatible changes to Hadoop (perhaps along with HADOOP-1230).

      1. MAPREDUCE-245.patch
        4 kB
        Tom White
      2. MAPREDUCE-245.patch
        6 kB
        Tom White
      3. MAPREDUCE-245.patch
        6 kB
        Chris Douglas

        Issue Links

          Activity

          Hide
          Tom White added a comment -

          A patch for the new job control API in the mapreduce package. The mapred package is left unchanged.

          Show
          Tom White added a comment - A patch for the new job control API in the mapreduce package. The mapred package is left unchanged.
          Hide
          Amareshwari Sriramadasu added a comment -

          Patch looks good.

          Show
          Amareshwari Sriramadasu added a comment - Patch looks good.
          Hide
          Chris Douglas added a comment -

          The patch does not compile (JobControl::castToJobList)

          Show
          Chris Douglas added a comment - The patch does not compile (JobControl::castToJobList)
          Hide
          Tom White added a comment -

          Here's a new patch which compiles, and passes the old and new job control tests (last time I thought I had successfully run the new tests, but clearly I hadn't).

          Show
          Tom White added a comment - Here's a new patch which compiles, and passes the old and new job control tests (last time I thought I had successfully run the new tests, but clearly I hadn't).
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12412070/MAPREDUCE-245.patch
          against trunk revision 791909.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12412070/MAPREDUCE-245.patch against trunk revision 791909. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/console This message is automatically generated.
          Hide
          Chris Douglas added a comment -

          Overlapping change conflicts; attaching trivial merge

          Show
          Chris Douglas added a comment - Overlapping change conflicts; attaching trivial merge
          Hide
          Chris Douglas added a comment -

          I committed this. Thanks, Tom!

          Show
          Chris Douglas added a comment - I committed this. Thanks, Tom!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #29 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/29/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #29 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/29/ )

            People

            • Assignee:
              Tom White
              Reporter:
              Tom White
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development