Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch. In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch. This issue proposes to re-enable those tests.

        Activity

        Hide
        Doug Cutting added a comment -

        Here's a patch that re-enables minimal tests. This does not yet re-enable tests of Yarn using Avro RPC, just the basic RPC test.

        Show
        Doug Cutting added a comment - Here's a patch that re-enables minimal tests. This does not yet re-enable tests of Yarn using Avro RPC, just the basic RPC test.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12476062/MAPREDUCE-2431.patch
        against trunk revision 1094093.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/176//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12476062/MAPREDUCE-2431.patch against trunk revision 1094093. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/176//console This message is automatically generated.
        Hide
        Arun C Murthy added a comment -

        Doug, thanks for the patch and apologies for the delay. The unit tests fail because it needs more work - specifically, you'll need to provide avro impls of the generic interfaces. Can you please update the patch and provide them? Thanks.

        Show
        Arun C Murthy added a comment - Doug, thanks for the patch and apologies for the delay. The unit tests fail because it needs more work - specifically, you'll need to provide avro impls of the generic interfaces. Can you please update the patch and provide them? Thanks.
        Hide
        Doug Cutting added a comment -

        I think the tests fail because Apache Hudson doesn't work on the MR-279 branch.

        The Avro impls of the generic interfaces were all present when MAPREDUCE-2414 was committed and when I contributed this patch. If you've chosen to abandon the use of Avro in this project, then perhaps you should make that clear and explain the rationale? Thanks!

        Show
        Doug Cutting added a comment - I think the tests fail because Apache Hudson doesn't work on the MR-279 branch. The Avro impls of the generic interfaces were all present when MAPREDUCE-2414 was committed and when I contributed this patch. If you've chosen to abandon the use of Avro in this project, then perhaps you should make that clear and explain the rationale? Thanks!
        Hide
        Arun C Murthy added a comment -

        I applied the patch and tried running tests which failed. Someone needs to implement the Avro impls for new interfaces. Can you help?

        Show
        Arun C Murthy added a comment - I applied the patch and tried running tests which failed. Someone needs to implement the Avro impls for new interfaces. Can you help?

          People

          • Assignee:
            Doug Cutting
            Reporter:
            Doug Cutting
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:

              Development