Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: tasktracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, it simply emits a warning. Then, when the taskjvm.sh tries to pipe its output into this directory, it fails with a strange error code like "exit code: 1" which is not intuitive to ops. Instead it should simply throw an exception at initialization time rather than attempting to run the task.

      1. mapreduce-2234.txt
        9 kB
        Todd Lipcon
      2. mapreduce-2234.txt
        1 kB
        Todd Lipcon

        Activity

        Hide
        Todd Lipcon added a comment -

        Now with more unit tests, plus some new unit tests for behavior with regard to permissions of mapred.local.dirs during startup.

        I'd be interested in people's opinions on something: if some (or all) of the mapred.local.dirs are unwritable when the TT starts up, should it shut itself down?

        Show
        Todd Lipcon added a comment - Now with more unit tests, plus some new unit tests for behavior with regard to permissions of mapred.local.dirs during startup. I'd be interested in people's opinions on something: if some (or all) of the mapred.local.dirs are unwritable when the TT starts up, should it shut itself down?
        Hide
        Tom White added a comment -

        +1 for the patch, pending Hudson.

        Show
        Tom White added a comment - +1 for the patch, pending Hudson.
        Hide
        Todd Lipcon added a comment -

        test-patch:
        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 6 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system test framework. The patch passed system test framework compile.

        Unit tests all passed except for the known timeouts.

        Show
        Todd Lipcon added a comment - test-patch: [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. Unit tests all passed except for the known timeouts.
        Hide
        Todd Lipcon added a comment -

        Committed to branch and trunk, thanks for reviewing Tom.

        Show
        Todd Lipcon added a comment - Committed to branch and trunk, thanks for reviewing Tom.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #572 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/572/)
        MAPREDUCE-2234. If Localizer can't create task log directory, it should fail on the spot. Contributed by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #572 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/572/ ) MAPREDUCE-2234 . If Localizer can't create task log directory, it should fail on the spot. Contributed by Todd Lipcon
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development