Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2054

Hierarchical queue implementation broke dynamic queue addition in Dynamic Scheduler

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.22.0
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fix Dynamic Priority Scheduler to work with hierarchical queue names

      Description

      Queue names were returned from the queue manager as an immutable set after the hierarchical queuname feature which breaks the dynamic priority scheduler

      1. MAPREDUCE-2054.patch
        2 kB
        Thomas Sandholm

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-22-branch #38 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/38/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #38 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/38/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #616 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/616/)
          MAPREDUCE-2054. Hierarchical queue implementation broke dynamic queue addition in Dynamic Scheduler. Contributed by Thomas Sandholm.

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #616 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/616/ ) MAPREDUCE-2054 . Hierarchical queue implementation broke dynamic queue addition in Dynamic Scheduler. Contributed by Thomas Sandholm.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Thomas!

          Show
          Tom White added a comment - I've just committed this. Thanks Thomas!
          Hide
          Thomas Sandholm added a comment -

          The bug that this patch fixes was due to a change in the real queumanager class
          which the scheduler test does not use in order to do roundtrip testing without setting up a full mapreduce cluster.

          Show
          Thomas Sandholm added a comment - The bug that this patch fixes was due to a change in the real queumanager class which the scheduler test does not use in order to do roundtrip testing without setting up a full mapreduce cluster.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12454123/MAPREDUCE-2054.patch
          against trunk revision 1074251.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/67//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/67//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/67//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12454123/MAPREDUCE-2054.patch against trunk revision 1074251. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/67//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/67//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/67//console This message is automatically generated.
          Hide
          Tom White added a comment -

          +1

          Do you want to manually run tests and test-patch as Hudson is not currently working.

          Show
          Tom White added a comment - +1 Do you want to manually run tests and test-patch as Hudson is not currently working.
          Hide
          Giridharan Kesavan added a comment -

          re-submiting to hudson

          Show
          Giridharan Kesavan added a comment - re-submiting to hudson
          Hide
          Thomas Sandholm added a comment -

          This patch is needed to run the Dynamic Priority Scheduler with any code base after the hierarchical queue names feature was added, including the 0.21 release

          Show
          Thomas Sandholm added a comment - This patch is needed to run the Dynamic Priority Scheduler with any code base after the hierarchical queue names feature was added, including the 0.21 release
          Hide
          Thomas Sandholm added a comment -

          tested against 0.21 branch

          Show
          Thomas Sandholm added a comment - tested against 0.21 branch

            People

            • Assignee:
              Thomas Sandholm
              Reporter:
              Thomas Sandholm
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development