Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1975

gridmix shows unnecessary InterruptedException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: contrib/gridmix
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The following InterruptedException is seen when gridmix is run and it ran successfully:

      10/06/24 20:43:03 INFO gridmix.ReplayJobFactory: START REPLAY @ 11331037109
      10/06/24 20:43:03 ERROR gridmix.Statistics: Statistics interrupt while waiting for polling null
      java.lang.InterruptedException
      at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObjec\
      t.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:1899)
      at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObjec\
      t.await(AbstractQueuedSynchronizer.java:2066)
      at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statis\
      tics.java:190)
      10/06/24 20:43:03 INFO gridmix.Gridmix: Exiting...

      1. 1975.patch
        0.9 kB
        Ravi Gummadi
      2. MR-1975.patch
        0.8 kB
        Ranjit Mathew
      3. 1975.v1.patch
        0.9 kB
        Ravi Gummadi

        Activity

        Hide
        Ravi Gummadi added a comment -

        Attaching patch fixing the issue. Ignoring the InterruptedException(instead of displaying the exception) if it comes from the methods shutdown() or abort().

        Show
        Ravi Gummadi added a comment - Attaching patch fixing the issue. Ignoring the InterruptedException(instead of displaying the exception) if it comes from the methods shutdown() or abort().
        Hide
        Amar Kamat added a comment -

        +1 for the fix. Can you upload test-patch and ant-test results?

        Show
        Amar Kamat added a comment - +1 for the fix. Can you upload test-patch and ant-test results?
        Hide
        Ravi Gummadi added a comment -

        Unit tests passed on my local machine.

        ant test-patch gave:

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        As I don't see an easy way to add a unit test for this, I did basic manual testing of the patch on a single node cluster and things seem to be fine.

        Show
        Ravi Gummadi added a comment - Unit tests passed on my local machine. ant test-patch gave: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. As I don't see an easy way to add a unit test for this, I did basic manual testing of the patch on a single node cluster and things seem to be fine.
        Hide
        Ranjit Mathew added a comment -

        Notice the "null" in the message "Statistics interrupt while waiting for polling null". This is
        because InterruptedException.getCause() is returning NULL in this case instead of a
        Throwable object. I think we should just be passing the exception as-is to the error()
        method.

        Show
        Ranjit Mathew added a comment - Notice the "null" in the message "Statistics interrupt while waiting for polling null". This is because InterruptedException.getCause() is returning NULL in this case instead of a Throwable object. I think we should just be passing the exception as-is to the error() method.
        Hide
        Ranjit Mathew added a comment -

        Here's a slightly-modified version of Ravi's patch that omits the call to getCause() as I noted earlier.

        Show
        Ranjit Mathew added a comment - Here's a slightly-modified version of Ravi's patch that omits the call to getCause() as I noted earlier.
        Hide
        Ravi Gummadi added a comment -

        Attaching new patch with slightly modified log message.

        Show
        Ravi Gummadi added a comment - Attaching new patch with slightly modified log message.
        Hide
        Ranjit Mathew added a comment -

        +1 from me.

        Show
        Ranjit Mathew added a comment - +1 from me.
        Hide
        Amareshwari Sriramadasu added a comment -

        I just committed this. Thanks Ravi !

        Show
        Amareshwari Sriramadasu added a comment - I just committed this. Thanks Ravi !
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )

          People

          • Assignee:
            Ravi Gummadi
            Reporter:
            Ravi Gummadi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development