Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1876

TaskAttemptStartedEvent.java incorrectly logs MAP_ATTEMPT_STARTED as event type for reduce tasks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TaskAttemptStartedEvent is used to log the start time of both the map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptStartedEvent

      /** Get the event type */
        public EventType getEventType() {
          return EventType.MAP_ATTEMPT_STARTED;
        }
      
      1. mapreduce-1876-v1.1.patch
        4 kB
        Amar Kamat
      2. mapreduce-1876-v1.2.patch
        4 kB
        Amar Kamat

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
          Hide
          Tom White added a comment -

          Backported to 0.21.0.

          Show
          Tom White added a comment - Backported to 0.21.0.
          Hide
          Amareshwari Sriramadasu added a comment -

          I just committed this. Thanks Amar!

          Show
          Amareshwari Sriramadasu added a comment - I just committed this. Thanks Amar!
          Hide
          Amar Kamat added a comment -

          All tests passed except TestSimulatorDeterministicReplay, which is a known issue. Not sure why so many tests failed with hudson.

          Show
          Amar Kamat added a comment - All tests passed except TestSimulatorDeterministicReplay, which is a known issue. Not sure why so many tests failed with hudson.
          Hide
          Amar Kamat added a comment -

          Failures are mostly either timeouts or MiniDFS class not found or DelegationToken errors. Doesnt seem related to this patch. Testing again on my local box.

          Show
          Amar Kamat added a comment - Failures are mostly either timeouts or MiniDFS class not found or DelegationToken errors. Doesnt seem related to this patch. Testing again on my local box.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12447688/mapreduce-1876-v1.2.patch
          against trunk revision 956779.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447688/mapreduce-1876-v1.2.patch against trunk revision 956779. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/259/console This message is automatically generated.
          Hide
          Amareshwari Sriramadasu added a comment -

          +1 latest patch looks fine.

          Show
          Amareshwari Sriramadasu added a comment - +1 latest patch looks fine.
          Hide
          Amar Kamat added a comment -

          Attaching a patch with Amareshwari's comment incorporated.

          Show
          Amar Kamat added a comment - Attaching a patch with Amareshwari's comment incorporated.
          Hide
          Amareshwari Sriramadasu added a comment -

          Fix looks fine. I have one comment in the testcase though.
          The last assert check in testcase should take TaskType as REDUCE, as we would never have a case where map attempt is run with reduce-id.

          Show
          Amareshwari Sriramadasu added a comment - Fix looks fine. I have one comment in the testcase though. The last assert check in testcase should take TaskType as REDUCE, as we would never have a case where map attempt is run with reduce-id.
          Hide
          Amar Kamat added a comment -

          Attaching a patch that uses the task-attempt-id to distinguish between map-tasktype and reduce-tasktype. Added a test for the same.

          Show
          Amar Kamat added a comment - Attaching a patch that uses the task-attempt-id to distinguish between map-tasktype and reduce-tasktype. Added a test for the same.

            People

            • Assignee:
              Amar Kamat
              Reporter:
              Amar Kamat
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development