Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1863

[Rumen] Null failedMapAttemptCDFs in job traces generated by Rumen

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: tools/rumen
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      All the traces generated by Rumen for jobs having failed task attempts has null value for failedMapAttemptCDFs.

      1. counters-test-trace.json.gz
        3 kB
        Amar Kamat
      2. dispatch-trace-output.json.gz
        27 kB
        Amar Kamat
      3. mr-1863-yhadoop-20.1xx.patch
        62 kB
        Hong Tang
      4. rumen-npe-v1.1.patch
        1 kB
        Amar Kamat
      5. rumen-npe-v1.1-bin.patch
        62 kB
        Amar Kamat

        Activity

        Amar Kamat created issue -
        Amar Kamat made changes -
        Field Original Value New Value
        Fix Version/s 0.22.0 [ 12314184 ]
        Affects Version/s 0.22.0 [ 12314184 ]
        Hide
        Amar Kamat added a comment -

        Attaching a patch that fixes the NPE. test-patch and ant-tests passed on my box. Note that this patch has resulted into changes to the following files

        src/test/tools/data/rumen/small-trace-test/dispatch-trace-output.json.gz
        src/test/tools/data/rumen/small-trace-test/counters-test-trace.json.gz
        

        Attached the same. The changes are that failedMapAttemptCDFs in the earlier expected-output files were null which is no longer the case.

        Show
        Amar Kamat added a comment - Attaching a patch that fixes the NPE. test-patch and ant-tests passed on my box. Note that this patch has resulted into changes to the following files src/test/tools/data/rumen/small-trace-test/dispatch-trace-output.json.gz src/test/tools/data/rumen/small-trace-test/counters-test-trace.json.gz Attached the same. The changes are that failedMapAttemptCDFs in the earlier expected-output files were null which is no longer the case.
        Amar Kamat made changes -
        Attachment rumen-npe-v1.1.patch [ 12447433 ]
        Attachment counters-test-trace.json.gz [ 12447434 ]
        Attachment dispatch-trace-output.json.gz [ 12447435 ]
        Amar Kamat made changes -
        Attachment counters-test-trace.json.gz [ 12447434 ]
        Amar Kamat made changes -
        Attachment dispatch-trace-output.json.gz [ 12447435 ]
        Hide
        Amar Kamat added a comment -

        Reattaching the expected output files.

        Show
        Amar Kamat added a comment - Reattaching the expected output files.
        Amar Kamat made changes -
        Attachment counters-test-trace.json.gz [ 12447436 ]
        Attachment dispatch-trace-output.json.gz [ 12447437 ]
        Hide
        Dick King added a comment -

        The code change looks right.

        Please add the binary files to the patch, which you need to do to get the Hudson job to work correctly.

        Show
        Dick King added a comment - The code change looks right. Please add the binary files to the patch, which you need to do to get the Hudson job to work correctly.
        Hide
        Amar Kamat added a comment -

        Attaching a patch that includes the binary diffs of the gold-standard files.

        Show
        Amar Kamat added a comment - Attaching a patch that includes the binary diffs of the gold-standard files.
        Amar Kamat made changes -
        Attachment rumen-npe-v1.1-bin.patch [ 12448019 ]
        Hide
        Amar Kamat added a comment -

        Running through hudson.

        Show
        Amar Kamat added a comment - Running through hudson.
        Amar Kamat made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12448019/rumen-npe-v1.1-bin.patch
        against trunk revision 957772.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448019/rumen-npe-v1.1-bin.patch against trunk revision 957772. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/268/console This message is automatically generated.
        Hide
        Amar Kamat added a comment -

        The contrib test failure is because of TestSimulatorDeterministicReplay timeout. This is a known issue, see MAPREDUCE-1834.

        Show
        Amar Kamat added a comment - The contrib test failure is because of TestSimulatorDeterministicReplay timeout. This is a known issue, see MAPREDUCE-1834 .
        Hide
        Chris Douglas added a comment -

        +1

        I committed this. Thanks, Amar!

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks, Amar!
        Chris Douglas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hong Tang added a comment -

        patch for yahoop hadoop 20.1xx branch. Not to be committed.

        Show
        Hong Tang added a comment - patch for yahoop hadoop 20.1xx branch. Not to be committed.
        Hong Tang made changes -
        Attachment mr-1863-yhadoop-20.1xx.patch [ 12448460 ]
        Amar Kamat made changes -
        Component/s tools/rumen [ 12313617 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Amar Kamat
            Reporter:
            Amar Kamat
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development