Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1780

AccessControlList.toString() is used for serialization of ACL in JobStatus.java

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixes serialization of job-acls in JobStatus to use AccessControlList.write() instead of AccessControlList.toString().

      Description

      HADOOP-6715 is created to fix AccessControlList.toString() for the case of WILDCARD. JobStatus.write() and readFields() assume that toString() returns the serialized String of AccessControlList object, which is not true. Once HADOOP-6715 gets fixed in COMMON, JobStatus.write() and JobStatus.readFields() should be fixed depending on the fix of HADOOP-6715.

      1. 1780.v1.patch
        8 kB
        Ravi Gummadi
      2. 1780.patch
        3 kB
        Ravi Gummadi

        Issue Links

          Activity

          Hide
          Ravi Gummadi added a comment -

          Attaching patch for trunk.

          This patch should go in after HADOOP-6715. This depends on the changes done in HADOOP-6715 to AccessControlList.toString() and AccessControlList.getAclString().

          Show
          Ravi Gummadi added a comment - Attaching patch for trunk. This patch should go in after HADOOP-6715 . This depends on the changes done in HADOOP-6715 to AccessControlList.toString() and AccessControlList.getAclString().
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Some comments:

          • JobSubmittedEvent is used to persist job-acls to JobHistory but the acls are incorrectly written through toString() method. Please add a test/modify the existing test in TestJobHistory to verify this bug.
          • Minor: Not directly related to the patch, but can fix it here. In QueueManger.dumpConfiguration(), we don't need aclsSubmitJobValue to be a StringBuilder. We can drop off getAclsInfo() method itself.
          Show
          Vinod Kumar Vavilapalli added a comment - Some comments: JobSubmittedEvent is used to persist job-acls to JobHistory but the acls are incorrectly written through toString() method. Please add a test/modify the existing test in TestJobHistory to verify this bug. Minor: Not directly related to the patch, but can fix it here. In QueueManger.dumpConfiguration(), we don't need aclsSubmitJobValue to be a StringBuilder. We can drop off getAclsInfo() method itself.
          Hide
          Ravi Gummadi added a comment -

          Attaching patch incorporating review comments.

          "Validation of job acls that are logged to history file" is added now to TestJobHistory. This somehow missed from trunk's patch of MAPREDUCE-1493, which was there in Y! dist patch.

          Show
          Ravi Gummadi added a comment - Attaching patch incorporating review comments. "Validation of job acls that are logged to history file" is added now to TestJobHistory. This somehow missed from trunk's patch of MAPREDUCE-1493 , which was there in Y! dist patch.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Looks good, +1 for the patch.

          Show
          Vinod Kumar Vavilapalli added a comment - Looks good, +1 for the patch.
          Hide
          Ravi Gummadi added a comment -

          Unit tests passed on my local machine.

          ant test-patch gave:

          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 9 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

          Show
          Ravi Gummadi added a comment - Unit tests passed on my local machine. ant test-patch gave: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          I just committed this to trunk. Thanks Ravi!

          Show
          Vinod Kumar Vavilapalli added a comment - I just committed this to trunk. Thanks Ravi!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )

            People

            • Assignee:
              Ravi Gummadi
              Reporter:
              Ravi Gummadi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development