Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1747

Remove documentation for the 'unstable' job-acls feature

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Removed the documentation for the 'unstable' job-acls feature from branch 0.21.

      Description

      As discussed here and here at MAPREDUCE-1604, the job-acls feature is currently unstable. Without MAPREDUCE-1664, job-acls are practically useless because of their problematic interactions with queue-acls. Removing them for 0.21 will both relieve ourselves of these problems as well as the burden to support the backwards compatibility of the configuration options as well as the going-to-be-changed semantics of the feature. This jira is about removing the documentation from 0.21 so that the completed feature can be added in 0.22 with ease.

      1. MAPREDUCE-1747-20100504.txt
        10 kB
        Vinod Kumar Vavilapalli
      2. MAPREDUCE-1747-20100420.txt
        11 kB
        Vinod Kumar Vavilapalli

        Issue Links

          Activity

          Hide
          Vinod Kumar Vavilapalli added a comment -

          I just committed this to branch 0.21.

          Show
          Vinod Kumar Vavilapalli added a comment - I just committed this to branch 0.21.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          The test-failure of TestUserLogCleanup is unrelated, it passed on my machine. Will create a ticket for that separately. Going to commit this to branch 0.21.

          Show
          Vinod Kumar Vavilapalli added a comment - The test-failure of TestUserLogCleanup is unrelated, it passed on my machine. Will create a ticket for that separately. Going to commit this to branch 0.21.
          Hide
          Ravi Gummadi added a comment -

          Patch looks good.
          +1 for this to go into 0.21

          Show
          Ravi Gummadi added a comment - Patch looks good. +1 for this to go into 0.21
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12443568/MAPREDUCE-1747-20100504.txt
          against trunk revision 941179.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443568/MAPREDUCE-1747-20100504.txt against trunk revision 941179. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/166/console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          I did sanity tests as suggested by Ravi with two queues. The machinery is all well-oiled. Will resubmit it to Hudson one more time just to be sure.

          Show
          Vinod Kumar Vavilapalli added a comment - I did sanity tests as suggested by Ravi with two queues. The machinery is all well-oiled. Will resubmit it to Hudson one more time just to be sure.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          MAPREDUCE-1749 broke this patch slightly. Going to upload an updated patch.

          Show
          Vinod Kumar Vavilapalli added a comment - MAPREDUCE-1749 broke this patch slightly. Going to upload an updated patch.
          Hide
          Ravi Gummadi added a comment -

          Patch looks good. Just to be on the safer side, I suggest some sanity testing of security related stuff including queue acls with mapred.acls.enabled set to (a) true and (b) false before commit.

          Show
          Ravi Gummadi added a comment - Patch looks good. Just to be on the safer side, I suggest some sanity testing of security related stuff including queue acls with mapred.acls.enabled set to (a) true and (b) false before commit.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12443268/MAPREDUCE-1747-20100420.txt
          against trunk revision 939505.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443268/MAPREDUCE-1747-20100420.txt against trunk revision 939505. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/530/console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Patch removing documentation. It removes javadoc, forrest documentation and downgrades the visibility of a few variables and classes from public to package-private. No other code-changes.

          Show
          Vinod Kumar Vavilapalli added a comment - Patch removing documentation. It removes javadoc, forrest documentation and downgrades the visibility of a few variables and classes from public to package-private. No other code-changes.

            People

            • Assignee:
              Vinod Kumar Vavilapalli
              Reporter:
              Vinod Kumar Vavilapalli
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development