[MAPREDUCE-1662] TaskRunner.prepare() and close() can be removed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.22.0
• Fix Version/s: 0.22.0
• Component/s: tasktracker
• Hadoop Flags: Reviewed
• Assignee: Amareshwari Sriramadasu
• Reporter: Amareshwari Sriramadasu
• Created: 01/Apr/10 05:47
• Updated: 12/Dec/11 06:18
• Resolved: 21/May/10 08:46

Description

TaskRunner.prepare() and close() methods call only mapOutputFile.removeAll(). The removeAll() call is a always a no-op in prepare(), because the directory is always empty during start up of the task. The removeAll() call in close() is useless, because it is followed by a attempt directory cleanup. Since the map output files are in attempt directory, the call to close() is useless.
After MAPREDUCE-842, these calls are under TaskTracker space, passing the wrong conf. Now, the calls do not make sense at all.
I think we can remove the methods.

Issue Links

• is related to: MAPREDUCE-1635 ResourceEstimator does not work after MAPREDUCE-842
• is related to: MAPREDUCE-1247 Send out-of-band heartbeat to avoid fake lost tasktracker