The patch has gone stale, needs update w.r.t TestWebUIAuthorization.
- The log statement after building acls should also log the configured admin acls. Same in TaskTracker.java
- Instead of getting the new configruation property and comparing it with mrOwner, it is better to create a Configuration object without loading default resources (Hemanth's smart tip!), get the configuration parameter and compare it will null.
- If the new configuration is not present, there is no need for augmenting mrOwner also to the ACL as we specially check for mrOwner everywhere. Correspondingly buildACLs() doesn't need to take mrOwner as a parameter.
Fix the javadoc for MR_SUPERGROUP and JT_SUPERGROUP. The link should be "
All tests should use the new configuration property only. We can add a simple unit test for handling deprecation in TestJobConf.
Still, there are some occurrences of the old configuration property. Can you do a (case-insensitive) grep for 'supergroup' on the source code and replace'em all?