Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1480

CombineFileRecordReader does not properly initialize child RecordReader

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      CombineFileRecordReader instantiates child RecordReader instances but never calls their initialize() method to give them the proper TaskAttemptContext.

      1. MAPREDUCE-1480.2.patch
        7 kB
        Aaron Kimball
      2. MAPREDUCE-1480.3.patch
        9 kB
        Aaron Kimball
      3. MAPREDUCE-1480.4.patch
        9 kB
        Aaron Kimball
      4. MAPREDUCE-1480.5.patch
        9 kB
        Aaron Kimball
      5. MAPREDUCE-1480.patch
        7 kB
        Aaron Kimball
      6. MAPREDUCE-1480-branch20.patch
        9 kB
        Aaron Kimball

        Issue Links

          Activity

          Hide
          Aaron Kimball added a comment -

          Attaching a patch for branch20. This applies cleanly on the Cloudera Distribution (CDH3), which also includes a backport of MAPREDUCE-1423.

          Since this is a bug in CombineFileInputFormat, this should be considered for application on Apache 0.20.3.

          Show
          Aaron Kimball added a comment - Attaching a patch for branch20. This applies cleanly on the Cloudera Distribution (CDH3), which also includes a backport of MAPREDUCE-1423 . Since this is a bug in CombineFileInputFormat, this should be considered for application on Apache 0.20.3.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #270 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/270/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #270 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/270/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #289 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/289/)
          . Correctly initialize child RecordReaders in
          CombineFileInputFormat. Contributed by Aaron Kimball

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #289 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/289/ ) . Correctly initialize child RecordReaders in CombineFileInputFormat. Contributed by Aaron Kimball
          Hide
          Chris Douglas added a comment -

          +1

          I committed this. Thanks, Aaron!

          Minor nit:

          +      curReader =  rrConstructor.newInstance(new Object [] 
          +                            {split, context, Integer.valueOf(idx)});
          

          Constructor::newInstance(Object...) supports the syntactic sugar eliding the explicit Object[] creation.

          Show
          Chris Douglas added a comment - +1 I committed this. Thanks, Aaron! Minor nit: + curReader = rrConstructor.newInstance(new Object [] + {split, context, Integer.valueOf(idx)}); Constructor::newInstance(Object...) supports the syntactic sugar eliding the explicit Object[] creation.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12439198/MAPREDUCE-1480.5.patch
          against trunk revision 924991.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439198/MAPREDUCE-1480.5.patch against trunk revision 924991. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/348/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          Tests failed due to classpath woes; giving this another spin for good measure.

          Show
          Aaron Kimball added a comment - Tests failed due to classpath woes; giving this another spin for good measure.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12439198/MAPREDUCE-1480.5.patch
          against trunk revision 924910.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439198/MAPREDUCE-1480.5.patch against trunk revision 924910. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/37/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          new patch synced with trunk.

          Show
          Aaron Kimball added a comment - new patch synced with trunk.
          Hide
          dhruba borthakur added a comment -

          Code looks good to me.

          Show
          dhruba borthakur added a comment - Code looks good to me.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12438662/MAPREDUCE-1480.4.patch
          against trunk revision 923907.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438662/MAPREDUCE-1480.4.patch against trunk revision 923907. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/35/console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12438662/MAPREDUCE-1480.4.patch
          against trunk revision 923907.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438662/MAPREDUCE-1480.4.patch against trunk revision 923907. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/526/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          Hudson seems stuck; recycling patch queue.

          Show
          Aaron Kimball added a comment - Hudson seems stuck; recycling patch queue.
          Hide
          Aaron Kimball added a comment -

          Test case caught an off-by-one error in progress calculation. Fixed with patch #4.

          Show
          Aaron Kimball added a comment - Test case caught an off-by-one error in progress calculation. Fixed with patch #4.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12438541/MAPREDUCE-1480.3.patch
          against trunk revision 922047.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438541/MAPREDUCE-1480.3.patch against trunk revision 922047. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/521/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          New patch addressing the above. Added a testReinit() testcase that checks multiple files in the same CombineFileSplit and ensures that initialize() got called correctly the second time.

          Dhruba, I agree that your proposed getProgress() method should work; I've folded it in here as well.

          Show
          Aaron Kimball added a comment - New patch addressing the above. Added a testReinit() testcase that checks multiple files in the same CombineFileSplit and ensures that initialize() got called correctly the second time. Dhruba, I agree that your proposed getProgress() method should work; I've folded it in here as well.
          Hide
          dhruba borthakur added a comment -

          Actually, while calculating subprogress, it shoudl take into account the size of the current split:

            public float getProgress() throws IOException {
              long subprogress = 0;    // bytes processed in current split
              if (null != curReader) {
                subprogress = (long)(curReader.getProgress() * split.getLength(idx));
              }
              return Math.min(1.0f,  (progress + subprogress)/(float)(split.getLength()));
            }
          
          Show
          dhruba borthakur added a comment - Actually, while calculating subprogress, it shoudl take into account the size of the current split: public float getProgress() throws IOException { long subprogress = 0; // bytes processed in current split if ( null != curReader) { subprogress = ( long )(curReader.getProgress() * split.getLength(idx)); } return Math .min(1.0f, (progress + subprogress)/( float )(split.getLength())); }
          Hide
          dhruba borthakur added a comment -

          The code to initialize the reader looks right. However, the getProgress() method might need some more work. here is my first attempt at it:

            public float getProgress() throws IOException {
              long subprogress = 0;    // bytes processed in current split
              if (null != curReader) {
                subprogress = (long)(curReader.getProgress() * split.getLength());
              }
              return Math.min(1.0f,  (progress + subprogress)/(float)(split.getLength()));
            }
          
          Show
          dhruba borthakur added a comment - The code to initialize the reader looks right. However, the getProgress() method might need some more work. here is my first attempt at it: public float getProgress() throws IOException { long subprogress = 0; // bytes processed in current split if ( null != curReader) { subprogress = ( long )(curReader.getProgress() * split.getLength()); } return Math .min(1.0f, (progress + subprogress)/( float )(split.getLength())); }
          Hide
          Aaron Kimball added a comment -

          Amareshwari,

          Thanks for looking over this patch.

          The previous progress calculator was strictly based on the number of sub-splits processed. The underlying RecordReader's getProgress() function was never called, which means that the granularity of progress was only based around the number of subsplits and did not take intra-split progress into account. A review from Dhruba is definitely welcome.

          I'll add another testcase as you suggest and post this in the next couple of days.

          Show
          Aaron Kimball added a comment - Amareshwari, Thanks for looking over this patch. The previous progress calculator was strictly based on the number of sub-splits processed. The underlying RecordReader's getProgress() function was never called, which means that the granularity of progress was only based around the number of subsplits and did not take intra-split progress into account. A review from Dhruba is definitely welcome. I'll add another testcase as you suggest and post this in the next couple of days.
          Hide
          Amareshwari Sriramadasu added a comment -

          Looked at the patch.
          I'm not sure about the correctness of progress calculation changes. Changes for RecordReader.initialize() look fine.
          Dhruba, Can you look at progress calculation change in the attached patch?

          Can you extend the test case to have more than one file, so that the method CombineFileRecordReader.initNextRecordReader() will also be tested? With the current test only the CombineFileRecordReader's constructor and initialize() method are tested.

          Show
          Amareshwari Sriramadasu added a comment - Looked at the patch. I'm not sure about the correctness of progress calculation changes. Changes for RecordReader.initialize() look fine. Dhruba, Can you look at progress calculation change in the attached patch? Can you extend the test case to have more than one file, so that the method CombineFileRecordReader.initNextRecordReader() will also be tested? With the current test only the CombineFileRecordReader's constructor and initialize() method are tested.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12435529/MAPREDUCE-1480.2.patch
          against trunk revision 908321.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435529/MAPREDUCE-1480.2.patch against trunk revision 908321. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/445/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          New patch does not call initialize() for the first child RecordReader instance right after constructor – that is handled by MapTask.

          Show
          Aaron Kimball added a comment - New patch does not call initialize() for the first child RecordReader instance right after constructor – that is handled by MapTask.
          Hide
          Aaron Kimball added a comment -

          Patch that fixes this problem and adds a test case demonstrating it.

          Show
          Aaron Kimball added a comment - Patch that fixes this problem and adds a test case demonstrating it.

            People

            • Assignee:
              Aaron Kimball
              Reporter:
              Aaron Kimball
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development