Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1212

Mapreduce contrib project ivy dependencies are not included in binary target

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As in HADOOP-6370, only Hadoop's own library dependencies are promoted to $

      {build.dir}

      /lib; any libraries required by contribs are not redistributed.

      1. MAPREDUCE-1212.patch
        1 kB
        Aaron Kimball
      2. MAPREDUCE-1212.3.patch
        12 kB
        Aaron Kimball
      3. MAPREDUCE-1212.2.patch
        11 kB
        Aaron Kimball

        Issue Links

          Activity

          Hide
          Aaron Kimball added a comment -

          Attaching patch which fixes this issue. Transitive dependencies in contrib/vertica and contrib/sqoop were pulling in commons-codec-1.2.jar, so I put explicit dependencies on commons-codec in their ivy.xml files to sync them to commons-codec-1.3.

          Note that the original motivation for this issue is that Sqoop depends on commons-io-1.4 but seems to be the only component of Hadoop that does so. Therefore, without this patch, Sqoop will not execute from a binary-only release. After this patch, commons-io-1.4.jar is put in the output "lib" dir correctly.

          Show
          Aaron Kimball added a comment - Attaching patch which fixes this issue. Transitive dependencies in contrib/vertica and contrib/sqoop were pulling in commons-codec-1.2.jar, so I put explicit dependencies on commons-codec in their ivy.xml files to sync them to commons-codec-1.3. Note that the original motivation for this issue is that Sqoop depends on commons-io-1.4 but seems to be the only component of Hadoop that does so. Therefore, without this patch, Sqoop will not execute from a binary-only release. After this patch, commons-io-1.4.jar is put in the output "lib" dir correctly.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12424766/MAPREDUCE-1212.patch
          against trunk revision 835237.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424766/MAPREDUCE-1212.patch against trunk revision 835237. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/137/console This message is automatically generated.
          Hide
          Tom White added a comment -

          Moving to open, pending discussion on HADOOP-6370.

          Show
          Tom White added a comment - Moving to open, pending discussion on HADOOP-6370 .
          Hide
          Aaron Kimball added a comment -

          New patch based on discussion in HADOOP-6370. All the common deps are copied into contrib/(projname)/lib except for those which are already in the global "lib" directory.

          Adds "test" ivy configurations to some contrib projects so that they do not pull in hadoop-hdfs-test and hadoop-core-test in "common" mode.

          Removed a few other spurious dependencies (e.g., slf-log4j) from some projects. They should be fine using the global log4j. (Since that's all we were shipping, anyway)

          Show
          Aaron Kimball added a comment - New patch based on discussion in HADOOP-6370 . All the common deps are copied into contrib/(projname)/lib except for those which are already in the global "lib" directory. Adds "test" ivy configurations to some contrib projects so that they do not pull in hadoop-hdfs-test and hadoop-core-test in "common" mode. Removed a few other spurious dependencies (e.g., slf-log4j) from some projects. They should be fine using the global log4j. (Since that's all we were shipping, anyway)
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12429500/MAPREDUCE-1212.2.patch
          against trunk revision 896265.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429500/MAPREDUCE-1212.2.patch against trunk revision 896265. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/249/console This message is automatically generated.
          Hide
          Tom White added a comment -

          +1 This looks good to me. I tried building a tarball with this patch and it successfully created lib subdirectories for index and sqoop, and they contained only the extra dependencies.

          Show
          Tom White added a comment - +1 This looks good to me. I tried building a tarball with this patch and it successfully created lib subdirectories for index and sqoop, and they contained only the extra dependencies.
          Hide
          Aaron Kimball added a comment -

          Forgot to define 'test' ivy configurations in dynamic-scheduler and mrunit, thus the '-1'. New patch.

          Show
          Aaron Kimball added a comment - Forgot to define 'test' ivy configurations in dynamic-scheduler and mrunit, thus the '-1'. New patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12429564/MAPREDUCE-1212.3.patch
          against trunk revision 896265.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429564/MAPREDUCE-1212.3.patch against trunk revision 896265. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/360/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          I don't see how the current crop of errors could be related.

          Show
          Aaron Kimball added a comment - I don't see how the current crop of errors could be related.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Aaron!

          Show
          Tom White added a comment - I've just committed this. Thanks Aaron!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #206 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/206/)
          . Mapreduce contrib project ivy dependencies are not included in binary target. Contributed by Aaron Kimball.

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #206 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/206/ ) . Mapreduce contrib project ivy dependencies are not included in binary target. Contributed by Aaron Kimball.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #225 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/225/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #225 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/225/ )

            People

            • Assignee:
              Aaron Kimball
              Reporter:
              Aaron Kimball
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development