Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1163

hdfsJniHelper.h: Yahoo! specific paths are encoded

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This header file defines USER_CLASSPATH as "/home/y/libexec/hadoop/conf:/home/y/libexec/hadoop/lib/hadoop-0.1.0.jar" .

      This define doesn't appear to actually be used anywhere. But it certainly would be a great way to exploit systems if it used internally at Yahoo!...

      1. MAPREDUCE-1163.patch
        0.4 kB
        Allen Wittenauer

        Activity

        Hide
        Allen Wittenauer added a comment -

        Moved this to MAPREDUCE, since that is where the code base lives.

        Show
        Allen Wittenauer added a comment - Moved this to MAPREDUCE, since that is where the code base lives.
        Hide
        Allen Wittenauer added a comment -

        Removes USER_CLASSPATH since it doesn't appear to even be used anywhere

        Show
        Allen Wittenauer added a comment - Removes USER_CLASSPATH since it doesn't appear to even be used anywhere
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423598/MAPREDUCE-1163.patch
        against trunk revision 831037.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423598/MAPREDUCE-1163.patch against trunk revision 831037. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/105/console This message is automatically generated.
        Hide
        Allen Wittenauer added a comment -

        This failed due to the flaky gridmix test i think.

        Show
        Allen Wittenauer added a comment - This failed due to the flaky gridmix test i think.
        Hide
        Chris Douglas added a comment -

        +1 Good catch

        I committed this. Thanks, Allen!

        Show
        Chris Douglas added a comment - +1 Good catch I committed this. Thanks, Allen!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #109 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/109/)
        . Remove unused, hard-coded paths from libhdfs. Contributed by Allen Wittenauer

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #109 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/109/ ) . Remove unused, hard-coded paths from libhdfs. Contributed by Allen Wittenauer

          People

          • Assignee:
            Allen Wittenauer
            Reporter:
            Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development