Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1158

running_maps is not decremented when the tasks of a job is killed/failed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fix Jobtracker running maps/reduces metrics.

      Description

      running_maps counter in the metrics is not decremented when the tasks of a job is killed/failed. Below are the exact steps to reproduce the problem:

      • Initially running_maps=0
      • Submit a job with 5 maps. running_maps is set to 5
      • Kill 2 attempts of a map task
      • Fail 4 attempts of the same map task so that the job is finally marked killed.
      • Once the job is marked killed, running_maps is set to 3 and not 0.
      1. 1158.patch
        8 kB
        Sharad Agarwal
      2. 1158_yahoo.patch
        7 kB
        Sharad Agarwal

        Activity

        Hide
        Sharad Agarwal added a comment -

        Currently runningMaps/runningReduces metrics is captured in JobInProgress. It was discussed in offline discussion with Hemanth and Amareshwari that right place would be to do in JobTracker where slot metrics is captured. Attaching patch doing the same.

        Show
        Sharad Agarwal added a comment - Currently runningMaps/runningReduces metrics is captured in JobInProgress. It was discussed in offline discussion with Hemanth and Amareshwari that right place would be to do in JobTracker where slot metrics is captured. Attaching patch doing the same.
        Hide
        Amareshwari Sriramadasu added a comment -

        Changes look fine to me.

        Show
        Amareshwari Sriramadasu added a comment - Changes look fine to me.
        Hide
        Sharad Agarwal added a comment -

        test patch passed:

         +1 overall.
             [exec]
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]
             [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
             [exec]
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec]
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        
        Show
        Sharad Agarwal added a comment - test patch passed: +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Hemanth Yamijala added a comment -

        Changes look fine to me.

        Show
        Hemanth Yamijala added a comment - Changes look fine to me.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423417/1158.patch
        against trunk revision 829529.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423417/1158.patch against trunk revision 829529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/97/console This message is automatically generated.
        Hide
        Sharad Agarwal added a comment -

        I just committed this.

        Show
        Sharad Agarwal added a comment - I just committed this.
        Hide
        Sharad Agarwal added a comment -

        Y! 0.20 patch.

        Show
        Sharad Agarwal added a comment - Y! 0.20 patch.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #100 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/100/)
        . Fix JT running maps and running reduces metrics. Contributed by Sharad Agarwal.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #100 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/100/ ) . Fix JT running maps and running reduces metrics. Contributed by Sharad Agarwal.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #127 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/127/)
        . Fix JT running maps and running reduces metrics. Contributed by Sharad Agarwal.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #127 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/127/ ) . Fix JT running maps and running reduces metrics. Contributed by Sharad Agarwal.

          People

          • Assignee:
            Sharad Agarwal
            Reporter:
            Ramya Sunil
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development