Mahout
  1. Mahout
  2. MAHOUT-888

Start using newly acquired reviewboard instance!

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: None
    • Labels:
      None

      Description

      It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.

      ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2872/
        -----------------------------------------------------------

        Review request for mahout.

        Summary
        -------

        This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888

        This addresses bug MAHOUT-888.
        https://issues.apache.org/jira/browse/MAHOUT-888

        Diffs


        trunk/README.txt 1203081

        Diff: https://reviews.apache.org/r/2872/diff

        Testing
        -------

        No code was changed, so no testing was done!

        Thanks,

        Jake

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2872/ ----------------------------------------------------------- Review request for mahout. Summary ------- This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888 This addresses bug MAHOUT-888 . https://issues.apache.org/jira/browse/MAHOUT-888 Diffs trunk/README.txt 1203081 Diff: https://reviews.apache.org/r/2872/diff Testing ------- No code was changed, so no testing was done! Thanks, Jake
        Hide
        Jake Mannix added a comment -

        not sure how to get this to automatically notice that https://reviews.apache.org/r/2872/ was linked to this ticket...

        Show
        Jake Mannix added a comment - not sure how to get this to automatically notice that https://reviews.apache.org/r/2872/ was linked to this ticket...
        Hide
        Jake Mannix added a comment -

        nevermind, there it magically is, I was too impatient!

        Show
        Jake Mannix added a comment - nevermind, there it magically is, I was too impatient!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2872/#review3314
        -----------------------------------------------------------

        trunk/README.txt
        <https://reviews.apache.org/r/2872/#comment7401>

        Scary trailing whitespace at the end of this line! Whitespace nazis would comment here telling me to kill it.

        trunk/README.txt
        <https://reviews.apache.org/r/2872/#comment7402>

        more trailing whitespace!

        • Jake

        On 2011-11-17 07:21:10, Jake Mannix wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2872/

        -----------------------------------------------------------

        (Updated 2011-11-17 07:21:10)

        Review request for mahout.

        Summary

        -------

        This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888

        This addresses bug MAHOUT-888.

        https://issues.apache.org/jira/browse/MAHOUT-888

        Diffs

        -----

        trunk/README.txt 1203081

        Diff: https://reviews.apache.org/r/2872/diff

        Testing

        -------

        No code was changed, so no testing was done!

        Thanks,

        Jake

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2872/#review3314 ----------------------------------------------------------- trunk/README.txt < https://reviews.apache.org/r/2872/#comment7401 > Scary trailing whitespace at the end of this line! Whitespace nazis would comment here telling me to kill it. trunk/README.txt < https://reviews.apache.org/r/2872/#comment7402 > more trailing whitespace! Jake On 2011-11-17 07:21:10, Jake Mannix wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2872/ ----------------------------------------------------------- (Updated 2011-11-17 07:21:10) Review request for mahout. Summary ------- This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888 This addresses bug MAHOUT-888 . https://issues.apache.org/jira/browse/MAHOUT-888 Diffs ----- trunk/README.txt 1203081 Diff: https://reviews.apache.org/r/2872/diff Testing ------- No code was changed, so no testing was done! Thanks, Jake
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2872/#review3315
        -----------------------------------------------------------

        Ship it!

        After intensive and thorough inspection, I'd agree to commit this

        • Sebastian

        On 2011-11-17 07:21:10, Jake Mannix wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2872/

        -----------------------------------------------------------

        (Updated 2011-11-17 07:21:10)

        Review request for mahout.

        Summary

        -------

        This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888

        This addresses bug MAHOUT-888.

        https://issues.apache.org/jira/browse/MAHOUT-888

        Diffs

        -----

        trunk/README.txt 1203081

        Diff: https://reviews.apache.org/r/2872/diff

        Testing

        -------

        No code was changed, so no testing was done!

        Thanks,

        Jake

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2872/#review3315 ----------------------------------------------------------- Ship it! After intensive and thorough inspection, I'd agree to commit this Sebastian On 2011-11-17 07:21:10, Jake Mannix wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2872/ ----------------------------------------------------------- (Updated 2011-11-17 07:21:10) Review request for mahout. Summary ------- This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888 This addresses bug MAHOUT-888 . https://issues.apache.org/jira/browse/MAHOUT-888 Diffs ----- trunk/README.txt 1203081 Diff: https://reviews.apache.org/r/2872/diff Testing ------- No code was changed, so no testing was done! Thanks, Jake
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2872/#review3317
        -----------------------------------------------------------

        Ship it!

        Sure. Why not.

        • Ted

        On 2011-11-17 07:21:10, Jake Mannix wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2872/

        -----------------------------------------------------------

        (Updated 2011-11-17 07:21:10)

        Review request for mahout.

        Summary

        -------

        This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888

        This addresses bug MAHOUT-888.

        https://issues.apache.org/jira/browse/MAHOUT-888

        Diffs

        -----

        trunk/README.txt 1203081

        Diff: https://reviews.apache.org/r/2872/diff

        Testing

        -------

        No code was changed, so no testing was done!

        Thanks,

        Jake

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2872/#review3317 ----------------------------------------------------------- Ship it! Sure. Why not. Ted On 2011-11-17 07:21:10, Jake Mannix wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2872/ ----------------------------------------------------------- (Updated 2011-11-17 07:21:10) Review request for mahout. Summary ------- This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888 This addresses bug MAHOUT-888 . https://issues.apache.org/jira/browse/MAHOUT-888 Diffs ----- trunk/README.txt 1203081 Diff: https://reviews.apache.org/r/2872/diff Testing ------- No code was changed, so no testing was done! Thanks, Jake
        Hide
        Hudson added a comment -

        Integrated in Mahout-Quality #1183 (See https://builds.apache.org/job/Mahout-Quality/1183/)
        'Fixes' MAHOUT-888 after two ship-it's

        jmannix : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203092
        Files :

        • /mahout/trunk/README.txt
        Show
        Hudson added a comment - Integrated in Mahout-Quality #1183 (See https://builds.apache.org/job/Mahout-Quality/1183/ ) 'Fixes' MAHOUT-888 after two ship-it's jmannix : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203092 Files : /mahout/trunk/README.txt

          People

          • Assignee:
            Jake Mannix
            Reporter:
            Jake Mannix
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development