Mahout
  1. Mahout
  2. MAHOUT-886

FPtree nodes multiply-added (becoming siblings in tree)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: None
    • Labels:
      None

      Description

      In FPGrowth#traverseAndBuildConditionalFPTreeData, while creating a conditional FPtree sometimes nodes are multiply-added as children of the same node, becoming siblings in the conditional tree.

        Activity

        tom pierce created issue -
        Hide
        tom pierce added a comment -

        Keep nodes from getting multiply added (becoming own siblings). There's a FPTree.toString() included; you can use this to log the tree structure at the patched locations in traverseAndBuildConditionalFPTreeData to observe malformed trees.

        Show
        tom pierce added a comment - Keep nodes from getting multiply added (becoming own siblings). There's a FPTree.toString() included; you can use this to log the tree structure at the patched locations in traverseAndBuildConditionalFPTreeData to observe malformed trees.
        tom pierce made changes -
        Field Original Value New Value
        Attachment MAHOUT-886.patch [ 12503661 ]
        tom pierce made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Sean Owen added a comment -

        It looks OK to me, and passes tests, and I trust that tom's looked into this enough to confirm it's a fix. Robin any thoughts before I commit?

        Show
        Sean Owen added a comment - It looks OK to me, and passes tests, and I trust that tom's looked into this enough to confirm it's a fix. Robin any thoughts before I commit?
        Sean Owen made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Sean Owen [ srowen ]
        Fix Version/s 0.6 [ 12316364 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Mahout-Quality #1179 (See https://builds.apache.org/job/Mahout-Quality/1179/)
        MAHOUT-886 avoid adding child nodes several times

        srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1202094
        Files :

        • /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPGrowth.java
        • /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPTree.java
        Show
        Hudson added a comment - Integrated in Mahout-Quality #1179 (See https://builds.apache.org/job/Mahout-Quality/1179/ ) MAHOUT-886 avoid adding child nodes several times srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1202094 Files : /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPGrowth.java /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPTree.java
        Sean Owen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Suneel Marthi made changes -
        Component/s Frequent Itemset/Association Rule Mining [ 12313060 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        13m 53s 1 tom pierce 14/Nov/11 19:53
        Patch Available Patch Available Resolved Resolved
        12h 55m 1 Sean Owen 15/Nov/11 08:49
        Resolved Resolved Closed Closed
        86d 5h 11m 1 Sean Owen 09/Feb/12 14:00

          People

          • Assignee:
            Sean Owen
            Reporter:
            tom pierce
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development