Mahout
  1. Mahout
  2. MAHOUT-886

FPtree nodes multiply-added (becoming siblings in tree)

        Details

          Description

          In FPGrowth#traverseAndBuildConditionalFPTreeData, while creating a conditional FPtree sometimes nodes are multiply-added as children of the same node, becoming siblings in the conditional tree.

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Mahout-Quality #1179 (See https://builds.apache.org/job/Mahout-Quality/1179/)
            MAHOUT-886 avoid adding child nodes several times

            srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1202094
            Files :

            • /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPGrowth.java
            • /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPTree.java
            Show
            Hudson added a comment - Integrated in Mahout-Quality #1179 (See https://builds.apache.org/job/Mahout-Quality/1179/ ) MAHOUT-886 avoid adding child nodes several times srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1202094 Files : /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPGrowth.java /mahout/trunk/core/src/main/java/org/apache/mahout/fpm/pfpgrowth/fpgrowth/FPTree.java
            Hide
            Permalink
            Sean Owen added a comment -

            It looks OK to me, and passes tests, and I trust that tom's looked into this enough to confirm it's a fix. Robin any thoughts before I commit?

            Show
            Sean Owen added a comment - It looks OK to me, and passes tests, and I trust that tom's looked into this enough to confirm it's a fix. Robin any thoughts before I commit?
            Hide
            Permalink
            tom pierce added a comment -

            Keep nodes from getting multiply added (becoming own siblings). There's a FPTree.toString() included; you can use this to log the tree structure at the patched locations in traverseAndBuildConditionalFPTreeData to observe malformed trees.

            Show
            tom pierce added a comment - Keep nodes from getting multiply added (becoming own siblings). There's a FPTree.toString() included; you can use this to log the tree structure at the patched locations in traverseAndBuildConditionalFPTreeData to observe malformed trees.

              People

              • Assignee:
                Sean Owen
                Reporter:
                tom pierce
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development