Mahout
  1. Mahout
  2. MAHOUT-882

TopItems.getTopUsers ignores rescoring

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6
    • Component/s: None
    • Labels:
      None

      Description

      I believe TopUsers.getTopUsers() is not properly handling the rescoredSimilarity:

      TopItems.getTopUsers:
      double rescoredSimilarity = rescorer == null ? similarity : rescorer.rescore(userID, similarity);
            if (!Double.isNaN(rescoredSimilarity) && (!full || rescoredSimilarity > lowestTopValue)) {
              topUsers.add(new SimilarUser(userID, similarity));
      

      It is checking rescoredSimilarity for everything, but then not passing it in like getTopItems does.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3h 28m 1 Sean Owen 12/Nov/11 11:42
        Resolved Resolved Closed Closed
        89d 2h 18m 1 Sean Owen 09/Feb/12 14:00
        Sean Owen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Mahout-Quality #1171 (See https://builds.apache.org/job/Mahout-Quality/1171/)
        MAHOUT-882 Actually used rescored value in one TopItems method. Also, fix SimilarUser issue along the way from MAHOUT-881

        srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201248
        Files :

        • /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/SimilarUser.java
        • /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java
        • /mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/GenericUserBasedRecommenderTest.java
        Show
        Hudson added a comment - Integrated in Mahout-Quality #1171 (See https://builds.apache.org/job/Mahout-Quality/1171/ ) MAHOUT-882 Actually used rescored value in one TopItems method. Also, fix SimilarUser issue along the way from MAHOUT-881 srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201248 Files : /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/SimilarUser.java /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java /mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/GenericUserBasedRecommenderTest.java
        Sean Owen made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Sean Owen added a comment -

        Ugh, that's been there for ages. I'll fix it and SimilarUser and adjust tests.

        Show
        Sean Owen added a comment - Ugh, that's been there for ages. I'll fix it and SimilarUser and adjust tests.
        Grant Ingersoll created issue -

          People

          • Assignee:
            Grant Ingersoll
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development