Uploaded image for project: 'Mahout'
  1. Mahout
  2. MAHOUT-882

TopItems.getTopUsers ignores rescoring

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.6
    • None
    • None

    Description

      I believe TopUsers.getTopUsers() is not properly handling the rescoredSimilarity:

      TopItems.getTopUsers:
      double rescoredSimilarity = rescorer == null ? similarity : rescorer.rescore(userID, similarity);
            if (!Double.isNaN(rescoredSimilarity) && (!full || rescoredSimilarity > lowestTopValue)) {
              topUsers.add(new SimilarUser(userID, similarity));
      

      It is checking rescoredSimilarity for everything, but then not passing it in like getTopItems does.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            gsingers Grant Ingersoll
            gsingers Grant Ingersoll
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment