Mahout
  1. Mahout
  2. MAHOUT-849

Wrong error messages in AbstractMatrix

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6
    • Component/s: None
    • Labels:
      None

      Description

      AbstractMatrix prints out the wrong number when checking cardinality in times(Vector) and times(Matrix).

      1. MAHOUT-849.patch
        1 kB
        Lance Norskog

        Activity

        Hide
        Sean Owen added a comment -

        Good eye. In fact there were several more similar bits of inconsistency. I cleaned them out here.

        Show
        Sean Owen added a comment - Good eye. In fact there were several more similar bits of inconsistency. I cleaned them out here.
        Hide
        Hudson added a comment -

        Integrated in Mahout-Quality #1111 (See https://builds.apache.org/job/Mahout-Quality/1111/)
        MAHOUT-849 fix CardinalityException args, standardize and clean up use of row/col args

        srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1187698
        Files :

        • /mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractMatrix.java
        Show
        Hudson added a comment - Integrated in Mahout-Quality #1111 (See https://builds.apache.org/job/Mahout-Quality/1111/ ) MAHOUT-849 fix CardinalityException args, standardize and clean up use of row/col args srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1187698 Files : /mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractMatrix.java
        Hide
        Lance Norskog added a comment -

        "Error: wanted 43, received 43". This usually indicates a bug

        Show
        Lance Norskog added a comment - "Error: wanted 43, received 43". This usually indicates a bug
        Hide
        Ted Dunning added a comment -

        It usually indicates a bug in the test, though. This usually indicates a type mismatch where the objects have the same string form.

        Show
        Ted Dunning added a comment - It usually indicates a bug in the test, though. This usually indicates a type mismatch where the objects have the same string form.
        Hide
        Lance Norskog added a comment -

        My code attempted to multiply two MxN matrices which gives this complaint string. The test probes a cardinality mistake, but just catches the CardinalityException. In this case the class and test are correct, but the error messages are confusing. The JUnit annotation that examines exceptions would need a "required string" to find this.

        Show
        Lance Norskog added a comment - My code attempted to multiply two MxN matrices which gives this complaint string. The test probes a cardinality mistake, but just catches the CardinalityException. In this case the class and test are correct, but the error messages are confusing. The JUnit annotation that examines exceptions would need a "required string" to find this.

          People

          • Assignee:
            Sean Owen
            Reporter:
            Lance Norskog
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development